node-core-utils icon indicating copy to clipboard operation
node-core-utils copied to clipboard

Set exit code when commands fail

Open mmarchini opened this issue 5 years ago • 3 comments

If I run git node land on a new machine with nothing configured, I'll get the instructions to set required variables, and then the process will exit with status code 0. In order for us to be able to use ncu on a Commit Queue, it needs to return the appropriate status codes when something goes wrong, otherwise automation won't work.

(I didn't check which other failures will exit with 0, but all failures should set the exit code to a non-zero code)

mmarchini avatar Jun 27 '20 01:06 mmarchini

Closed by https://github.com/nodejs/node-core-utils/pull/443

codebytere avatar Jun 28 '20 03:06 codebytere

I'd like to keep this open because there are still many situations where the exit code will return zero even if the command failed. Would be good for us to list those as a next step.

mmarchini avatar Jun 28 '20 04:06 mmarchini

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Sep 27 '20 00:09 github-actions[bot]