Release icon indicating copy to clipboard operation
Release copied to clipboard

Grant release team maintainer access to release-related tooling

Open BethGriggs opened this issue 5 years ago • 15 comments

#547 opened further questions about the structure of the Release WG. It has been discussed that release team should have some responsibility over release related tooling.

  • [ ] Grant @nodejs/releasers write access to release related tooling
    • [x] changelog-maker
    • [ ] commit-stream
    • [x] branch-diff
    • [ ] node-core-utils
    • [x] citgm

BethGriggs avatar Mar 26 '20 17:03 BethGriggs

FWIW There's a shadow @nodejs/citgm-admins team that is used to control edit access to the CITGM CI jobs. We can probably keep the name of that group as-is.

richardlau avatar Mar 26 '20 17:03 richardlau

+1

On Thu, Mar 26, 2020 at 1:15 PM Richard Lau [email protected] wrote:

FWIW There's a shadow @nodejs/citgm-admins https://github.com/orgs/nodejs/teams/citgm-admins team that is used to control edit access to the CITGM CI jobs. We can probably keep the name of that group as-is.

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/nodejs/Release/issues/557#issuecomment-604557403, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADZYV4YXLDGX6DW2KSMWVTRJOESXANCNFSM4LUMUBEA .

MylesBorins avatar Mar 26 '20 23:03 MylesBorins

+1

gdams avatar Mar 27 '20 09:03 gdams

+1

mhdawson avatar Apr 01 '20 21:04 mhdawson

+1

joyeecheung avatar Apr 04 '20 08:04 joyeecheung

BTW I opened https://github.com/nodejs/admin/issues/488

joyeecheung avatar Apr 04 '20 08:04 joyeecheung

If we don't want to move forward with this work we should probably close this issue

MylesBorins avatar Jan 13 '22 15:01 MylesBorins

  • [ ] Grant release-automation write access to release related tooling
    • [ ] changelog-maker
    • [ ] branch-diff
    • [ ] node-core-utils

The last few times this issue has come up in Release WG meetings the consensus has been to add @nodejs/releasers to these repositories rather than creating a new team or repurposing the citgm team.

richardlau avatar Apr 14 '22 15:04 richardlau

Opened

  • https://github.com/nodejs/branch-diff/issues/51
  • https://github.com/nodejs/changelog-maker/issues/128

richardlau avatar Apr 14 '22 15:04 richardlau

This was discussed in https://github.com/nodejs/Release/issues/735. We no longer plan to rename the CITGM team. Instead, this issue can be closed once the releaser have been granted maintainer access to the mentioned repositories. I've updated the issue description accordingly.

BethGriggs avatar May 05 '22 10:05 BethGriggs

Opened

Given no objections and a 👍 I've added the releasers team to https://github.com/nodejs/branch-diff and https://github.com/nodejs/changelog-maker.

richardlau avatar May 05 '22 11:05 richardlau

Opened https://github.com/nodejs/node-core-utils/issues/628 for node-core-utils.

richardlau avatar May 05 '22 11:05 richardlau

Based on https://github.com/nodejs/citgm/pull/901#issuecomment-1118513519 I've added citgm to the list. I'll open an issue for it in the citgm repository.

richardlau avatar May 05 '22 13:05 richardlau

Should https://github.com/nodejs/commit-stream be added to this list of repos?

bengl avatar May 05 '22 17:05 bengl

Should https://github.com/nodejs/commit-stream be added to this list of repos?

Added commit-stream to the list.

BethGriggs avatar Jun 29 '22 11:06 BethGriggs