google-spell-check icon indicating copy to clipboard operation
google-spell-check copied to clipboard

Published 20 hours ago • verified publisher icon noahcoad

Replaces highlighted text with Javascript

Open Ezard opened this issue 10 years ago • 12 comments

Worked on some text the first time, then for every attempt after that, the highlighted text was replaced with a large amount of Javascript code

Ezard avatar Nov 15 '14 19:11 Ezard

Same thing happen here, sublime text 3, mac os 10.10

jCrip avatar Dec 09 '14 16:12 jCrip

Same here :(

danparker92 avatar Dec 19 '14 18:12 danparker92

From the README.md:

BTW, this uses a standard Google search page results instead of the Google API. This is nice in that an API key isn't required, but isn't 100% officially supported, so Google changing their URL schema could break the plugin.

:disappointed:

sudopeople avatar Dec 29 '14 19:12 sudopeople

Yup, I also have javascript on some of my corrections :disappointed:

ghost avatar Dec 30 '14 20:12 ghost

This is the same issue as #18.

TimothyGu avatar Jan 04 '15 00:01 TimothyGu

Ditto. Sublime3, Yosemite.

peterorum avatar Jan 07 '15 12:01 peterorum

Google embeds language file inside the webpage, which has made the Regex in google-spell-check.py#L29 matching the wrong content.

Simply stick a > in front of the regex to workaround this problem.

My quick and dirty fix:

  1. Unzip Google Spell Check.sublime-package
  2. Remove any *.pyc file.
  3. Open google-spell-check.py
  4. Fix the Regex, ... search (r'>( ...
  5. Zip everything
  6. Rename & replace Google Spell Check.sublime-package.
  7. Restart sublime text.

jixunmoe avatar Jan 26 '15 20:01 jixunmoe

@JixunMoe Brilliant, thanks for that 'dirty' fix.

codepuncher avatar Feb 03 '15 15:02 codepuncher

I've fixed this in pull #21.

Doggie52 avatar Apr 06 '15 11:04 Doggie52

Not sure if the fix was merged or not, but I just installed this plugin and it still happening for me.

Followed @JixunMoe's steps and it worked, it doesn't inject JS anymore.

ricardozea avatar Apr 16 '15 14:04 ricardozea

@ricardozea it hasn't been merged yet, waiting to hear back from @noahcoad .

Doggie52 avatar Apr 16 '15 14:04 Doggie52

It's been quite some time. Has @noahcoad abandoned this very useful package?

bobrocke avatar Aug 07 '15 23:08 bobrocke