libhoney-rust icon indicating copy to clipboard operation
libhoney-rust copied to clipboard

feat: runtime-async-std

Open Fishrock123 opened this issue 4 years ago • 3 comments

Adds a compile-time flag to support running on async-std's threadpool rather than a tokio one.

This also switches out Reqwest for Surf, which has multiple http client backends, including a Hyper (tokio-compatible) one.

Note: these feature flags are mutually exclusive, and building does not work if none is specified (i.e. --no-default-features).

cc @nlopes

Fishrock123 avatar Nov 26 '20 01:11 Fishrock123

Apologies @Fishrock123 but I merged a PR that improved things a bit with reqwest (in terms of dependencies) but that will force you to rebase.

I also noticed that tests didn't successfully run, something to take a look at.

Overall I like this change (the smaller the footprint the better).

nlopes avatar Dec 10 '20 10:12 nlopes

Ah shoot. It would have been easier to merge that after since surf is still playing catch-up a bit here.

Fishrock123 avatar Dec 10 '20 17:12 Fishrock123

is this work resumable @Fishrock123? :)

ericsampson avatar Jul 28 '21 01:07 ericsampson