EtherCard icon indicating copy to clipboard operation
EtherCard copied to clipboard

About client_postval

Open nopnop2002 opened this issue 5 years ago • 0 comments

Thank you for great wrok.

I have a small problem.

https://github.com/njh/EtherCard/blob/master/src/tcpip.cpp#L47

 static const char *client_postval;

https://github.com/njh/EtherCard/blob/master/src/tcpip.cpp#L542

    if (client_postval == 0) {

https://github.com/njh/EtherCard/blob/master/src/tcpip.cpp#L562

                     strlen(client_postval),

https://github.com/njh/EtherCard/blob/master/src/tcpip.cpp#L588

client_postval = 0;

https://github.com/njh/EtherCard/blob/master/src/tcpip.cpp#L597

client_postval = postval;

These code may cause an error in the future.

client_postval = 0; --> client_postval = "";

if (client_postval == 0) --> if (strlen(client_postval) == 0)

Thank you.

nopnop2002 avatar May 24 '20 14:05 nopnop2002