nixvim icon indicating copy to clipboard operation
nixvim copied to clipboard

some-modules-and-internal-refactor

Open jooooscha opened this issue 3 years ago • 2 comments

Related to #35

jooooscha avatar Aug 26 '22 13:08 jooooscha

I think the best way moving forward would be to create individual PRs for each separate component

I did not do a good job at making clean commits. Separating this now would take a lot of time. I suggest preparing everything so that we both are happy and then merging this at once.

jooooscha avatar Aug 27 '22 22:08 jooooscha

I did not do a good job at making clean commits. Separating this now would take a lot of time. I suggest preparing everything so that we both are happy and then merging this at once.

I'd rather wait for #34 to be merged then. Still, I might cherry-pick some changes from this onto the repo for now, will see.

pta2002 avatar Aug 27 '22 22:08 pta2002

Hey there, sorry for leaving this open for so long. Unfortunately due to the sheer amount of changes there is honestly no real way I can merge this all at once. Sorry for leaving this hanging for so long, I guess I let myself believe I'd get to it eventually, but at this point I think it's fair to say that I'm not really capable of taking this up in this state on my own.

So even though it hurts letting all these contributions go, for the sake of my sanity I'll be closing the PR. I do very much encourage you to submit these individually if you're interested; if not, I have added all of your changes into my personal nixvim ideas list so that I can add them individually in the future, in a more manageable way.

pta2002 avatar Jan 06 '23 22:01 pta2002

I have changed even more in the meantime (mostly API changes, clean-ups, and some new modules), so merging my changes to your project would likely not be possible, anyway. I, also, think contributing them individually does not make sense anymore.

In case you or anyone is interested, you can find my fork via my profile. (Don't want to advertise for it here)

jooooscha avatar Jan 31 '23 09:01 jooooscha