nixvim icon indicating copy to clipboard operation
nixvim copied to clipboard

[PLUGIN REQUEST] harpoon2

Open nicolasauler opened this issue 1 year ago • 5 comments

Field Description
Plugin harpoon2
Homepage https://github.com/ThePrimeagen/harpoon/tree/harpoon2
Nixpkgs https://search.nixos.org/packages?channel=unstable&show=vimPlugins.harpoon2&from=0&size=50&sort=relevance&type=packages&query=harpoon2

Extra Information

harpoon2 introduces breaking changes to harpoon (1)

nicolasauler avatar Apr 21 '24 00:04 nicolasauler

i am pretty sure this has been discussed and decided that we're waiting for harpoon2 to become the default before switching.

4lxs avatar Apr 23 '24 05:04 4lxs

Indeed. Harpoon 2 has not yet been officially released. Hence, in the meantime, we will sick on harpoon 1. I have already started to adapt the nixvim module on my side.

I will leave this issue open to track this migration.

GaetanLepage avatar Apr 23 '24 07:04 GaetanLepage

i am pretty sure this has been discussed and decided that we're waiting for harpoon2 to become the default before switching.

Sorry mate! I checked the issues for anything harpoon2 related, but couldn't find any open or closed ones, that's why I opened this one.

I will leave this issue open to track this migration.

Great! Thanks Gaetan.

nicolasauler avatar Apr 23 '24 14:04 nicolasauler

Sorry mate! I checked the issues for anything harpoon2 related, but couldn't find any open or closed ones, that's why I opened this one.

No problem :) Maybe it was on the matrix or somewhere else, I don't remember.

GaetanLepage avatar Apr 23 '24 14:04 GaetanLepage

As per discussion on matrix, I think we should add harpoon2 alongside harpoon.

  • Rename plugins.harpoon to plugins.harpoon1
  • Add pluigins.harpoon2
  • Add a "transition alias" pointing to either plugins.harpoon1 or plugins.harpoon2
  • Print a warning when the alias is used, such as: "plugins.harpoon is an alias for plugins.harpoon1. After 24.11 plugins.harpoon2 will be moved to plugins.harpoon. Use plugins.harpoon1 or plugins.harpoon2 to silence this warning"

One thing I don't like about this approach, is it implies we will always have three plugins.harpoon* modules (one of which being an alias), though idk if that's a real issue or just a small ugliness?

MattSturgeon avatar Jun 21 '24 08:06 MattSturgeon