nixvim icon indicating copy to clipboard operation
nixvim copied to clipboard

Update flake.lock

Open GaetanLepage opened this issue 1 year ago • 1 comments

Automated changes by the update-flake-lock GitHub Action.

Flake lock file updates:

• Updated input 'flake-parts':
    'github:hercules-ci/flake-parts/f7b3c975cf067e56e7cda6cb098ebe3fb4d74ca2' (2024-03-01)
  → 'github:hercules-ci/flake-parts/9126214d0a59633752a136528f5f3b9aa8565b7d' (2024-04-01)
• Updated input 'home-manager':
    'github:nix-community/home-manager/c0ef0dab55611c676ad7539bf4e41b3ec6fa87d2' (2024-03-28)
  → 'github:nix-community/home-manager/80546b220e95a575c66c213af1b09fe255299438' (2024-04-02)
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/d8fe5e6c92d0d190646fb9f1056741a229980089' (2024-03-29)
  → 'github:NixOS/nixpkgs/08b9151ed40350725eb40b1fe96b0b86304a654b' (2024-04-03)
• Updated input 'pre-commit-hooks':
    'github:cachix/pre-commit-hooks.nix/c11e43aed6f17336c25cd120eac886b96c455731' (2024-03-30)
  → 'github:cachix/pre-commit-hooks.nix/e35aed5fda3cc79f88ed7f1795021e559582093a' (2024-04-02)

Running GitHub Actions on this PR

GitHub Actions will not run workflows on pull requests which are opened by a GitHub Action.

To run GitHub Actions workflows on this PR, run:

git branch -D update_flake_lock_action
git fetch origin
git checkout update_flake_lock_action
git commit --amend --no-edit
git push origin update_flake_lock_action --force

GaetanLepage avatar Apr 03 '24 19:04 GaetanLepage

Let's wait for https://github.com/NixOS/nixpkgs/pull/301342 to land on nixos-unstable and then updating again.

GaetanLepage avatar Apr 03 '24 21:04 GaetanLepage

I will merge this later today as it unblocks many people that wish to update their config.

GaetanLepage avatar Apr 07 '24 13:04 GaetanLepage

If we need to fix urgenly things we should avoid doing work like switching to mkNeovimPlugin

traxys avatar Apr 07 '24 18:04 traxys

If we need to fix urgenly things we should avoid doing work like switching to mkNeovimPlugin

I agree, but for the two plugins in question, I didn't want to first introduce rename warnings to rewrite the plugin a few days later. I preferred to tackle this up front.

GaetanLepage avatar Apr 07 '24 18:04 GaetanLepage

If we need to fix urgenly things we should avoid doing work like switching to mkNeovimPlugin

I agree, but for the two plugins in question, I didn't want to first introduce rename warnings to rewrite the plugin a few days later. I preferred to tackle this up front.

Yes but it makes a huge PR that is very awkard to review...

traxys avatar Apr 07 '24 18:04 traxys

(In other words this is moving work from the author to the reviewer, and I feel this is never a good compromise, because reviewing is often harder than writing something)

traxys avatar Apr 07 '24 18:04 traxys

If we need to fix urgenly things we should avoid doing work like switching to mkNeovimPlugin

I agree, but for the two plugins in question, I didn't want to first introduce rename warnings to rewrite the plugin a few days later. I preferred to tackle this up front.

Yes but it makes a huge PR that is very awkard to review...

Yes sorry... This update was massive. I am still waiting for more upstream fixes.

GaetanLepage avatar Apr 07 '24 18:04 GaetanLepage