nixvim icon indicating copy to clipboard operation
nixvim copied to clipboard

plugins/tmux-navigator: Add keymap config options

Open MattSturgeon opened this issue 1 year ago • 4 comments

First time opening a PR here, so let me know if I've missed some etiquette.

Summary

  • New option tmuxNavigatorNoMappings maps to global tmux_navigator_no_mappings
  • New attrset keymaps maps keymaps to the various :TmuxNavigate* commands
    • Set of either enum or mapConfigOptions submodule (with some tweaks)

Future refactoring

I don't see why the various options should include the tmuxNavigator prefix; that is surely implied by being in the tmux-navigator plugin...

I also think that the null or 1 options could be refactored as bool options, to make more sense in nix...

I can open this as a separate issue/PR if it warrants discussion, or I could lump it into this PR if that's easier to review?

MattSturgeon avatar Mar 17 '24 16:03 MattSturgeon

I don't see why the various options should include the tmuxNavigator prefix; that is surely implied by being in the tmux-navigator plugin...

I also think that the null or 1 options could be refactored as bool options, to make more sense in nix...

I can open this as a separate issue/PR if it warrants discussion, or I could lump it into this PR if that's easier to review?

IMO this PR should be reworked after the plugin is ported to mkVimPlugin. I've opened #1293 to do that.

MattSturgeon avatar Mar 19 '24 20:03 MattSturgeon

Is this PR still relevant ? If so, it is necessary to rebase it on main as it has been a while ^^

GaetanLepage avatar Apr 23 '24 07:04 GaetanLepage

cc @MattSturgeon

GaetanLepage avatar Apr 26 '24 09:04 GaetanLepage

Unless I have some time to kill sooner, I'll take a look when I get back to the UK.

It'll probably need a rewrite due to #1293.

MattSturgeon avatar Apr 26 '24 15:04 MattSturgeon