home-manager

home-manager copied to clipboard

Description

Add an option to enable the GTK4 theming added in #4770 and disable it by default. Fixes #5133.

Checklist

• [x] Change is backwards compatible.

• [x] Code formatted with ./format.

• [x] Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

• [ ] Test cases updated/added. See example.

• [x] Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • [ ] Added myself as module maintainer. See example.

Maintainer CC

@rycee

@jkopanski

Yeah, separating gtk4 theming might be a good idea. I will take a look at that soon (probably this week, but I can't promise anything because I'm pretty busy atm). Oh, and I just noticed a typo in my commit here (gtkk instead of gtk4).

I think this should also prevent setting gtk-theme-name in the gtkIni for gtk4 variant. Otherwise it still tries to apply theme, and breaks if the selected one has poor gtk4 compatibility

Does this mean that the comment in the user.css file is wrong? It seems to suggest that the gtk-theme-name option is ignored for GTK4.

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

• GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
• If it is unfinished but you plan to finish it, please mark it as a draft.
• If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
• To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

• If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

Not stale, still very nuch an issue.