Nim icon indicating copy to clipboard operation
Nim copied to clipboard

Markdown code blocks part 4

Open a-mr opened this issue 3 years ago • 0 comments

No logic was added, just 8 more files have been migrated.

a-mr avatar Aug 09 '22 19:08 a-mr

Something I've been meaning to ask. There was a regression in the parser which caused it to fail on things like:

some sentence which will fail the parsing of the following block
\```
CodeBlock()
\```

this works, note the extra newline

\```
CodeBlock()
\```

Do you know if this has been fixed?

dom96 avatar Aug 10 '22 12:08 dom96

@dom96 No, it's still there, I did not know/remember about that. If it's essential (for nim forum, I guess?), then I will soon fix it with backport to 1.6. It should be pretty easy.

a-mr avatar Aug 10 '22 19:08 a-mr

yeah, if you could that would be brilliant, it means lots of forum posts aren't rendering :/

dom96 avatar Aug 10 '22 22:08 dom96

Thanks for your hard work on this PR! The lines below are statistics of the Nim compiler built from 713f39083ee37085ba24345af741e5b448fdcc05

Hint: mm: orc; threads: on; opt: speed; options: -d:release 163645 lines; 11.923s; 841.684MiB peakmem

github-actions[bot] avatar Aug 12 '22 18:08 github-actions[bot]