rust-pgn-reader icon indicating copy to clipboard operation
rust-pgn-reader copied to clipboard

Regain performance lost after switch from mmap to buffered IO

Open niklasf opened this issue 6 years ago • 2 comments

niklasf avatar Jan 29 '19 20:01 niklasf

Does this mean the benchmarks on https://github.com/niklasf/rust-pgn-reader are no longer valid? Can one simply use an older version to still achieve those speeds?

thomasahle avatar Jan 05 '21 13:01 thomasahle

The benchmarks (v0.12.0) are after this regression.

You can downgrade to v0.11.0 to use the mmap based reader for even better speeds, but there have been bugfixes in dependencies, added features, and there is some controversy about using mmap in Rust.

niklasf avatar Jan 05 '21 13:01 niklasf