Nicolas Franck

Results 140 comments of Nicolas Franck

This seems more like a "problem" in the image server, rather than in the viewer. A viewer does not inspect the image data, nor does the api specify any attributes...

Same here, both for v2 and v3 manifests: * v2: https://heaney0.ugent.be/IIIF/manifests/archive.ugent.be%3A3C37B88E-0BE3-11E6-9682-B54FF264C48D * v3: https://heaney0.ugent.be/custom-manifests/v3_manifest.json instead of seeing a dialog saying that you have to login, you are presented with a...

Besides, that `HeaderPanel.showInformation` is given an array of objects (of type `InformationArgs`), while it is treated as if it is given only one object. That is why this [line](https://github.com/UniversalViewer/universalviewer/blob/main/src/content-handlers/iiif/modules/uv-shared-module/HeaderPanel.ts#L148) return...

Mm, the interpretation as a degraded resource has probably something to do with this [line](https://github.com/IIIF-Commons/manifold/blob/e3998b2818be0fad8781a901a13f29bbfae43cc9/src/ExternalResource.ts#L478): if your image id contains an url encoded path, then the encoded path is different,...

@stephenwf yes it works! Weird, I build the last version of the master branch, because I found some recent changes about authentication from you, but that didn't work.. Some other...

It starts to work if I change these lines (https://github.com/UniversalViewer/universalviewer/blob/master/src/modules/uv-shared-module/BaseExtension.ts#L53) ``` Auth09.publish = this.component.publish; Auth1.publish = this.component.publish; ``` to ``` Auth09.publish = function(){ that.component.publish.apply(that.component,arguments); }; Auth1.publish = function(){ that.component.publish.apply(that.component,arguments); };...

@stephenwf now `this` equals `Extension`, instead of `UVComponent` when `UVComponent.prototype.publish` is called (add a log statement to see this). Changing `bind(this)` to `bind(this.component)` fixes part of the problem. But then...

Same goes for: * https://github.com/UniversalViewer/universalviewer/blob/master/src/modules/uv-dialogues-module/AuthDialogue.ts#L29 : argument `e` is an array, but is used as an object * https://github.com/UniversalViewer/universalviewer/blob/master/src/modules/uv-shared-module/HeaderPanel.ts#L130 : argument `args` is an array, but is used as an...

Ah, I did not imply to support v3 manifests, I only wanted to show that version 3 manifests slip through the current identification, and then fail during parse time, because...

is that manifest even valid? In presentation api v3 there are no sequences anymore..