ngx-scroll-to

ngx-scroll-to copied to clipboard

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request

Current behavior

No way to execute a callback after scrolling has completed

Expected behavior

define a config parameter for a completion callback

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

I want to execute additional animations after the scrolling.

Environment

Angular version: X.Y.Z


Your version of `@nicky-lenaers/ngx-scroll-to`:


Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

Hi @gang-qiu , thank you for your issue. This is certainly a good feature. I'm currently working on fixing some other issues. Please check back in a short while for this feature.

Thanks! 💯

Hi @nicky-lenaers, This feature would be a huge addition to the plugin. We are using it in production and our client just ask some extra behavior right after scroll ends and for now it's impossible to do it without this feature. Do you have a prevision when you can make it available? Thanks and congrats for the amazing plugin :)

Hi! You can use third callback in Observable subscription like this

this.scrollToService
  .scrollTo({ target })
  .subscribe(null, null, () => console.log('Scroll completed!'));