ngx-scroll-to
ngx-scroll-to copied to clipboard
nicky-lenaers
feat(lib): support for angular v13
refactor: replace tslint with eslint refactor: change protractor to cypress build: update third party libraries
@nicky-lenaers Could please take this up?
I will merge this PR and publish the new version ASAP
Thanks @rafa-as , I am not actively maintaining this package anymore
Would you mind signing it over? The package is still very popular and useful to many people.
BTW: I wrote you a mail some months ago about it, but haven't received a reply yet.
@andreas-aeschlimann Thanks for your reply. I must have overlooked your email (still can't find it though), sorry for that. I added you as a collaborator to this repo. Is this sufficient for you to continue?
@andreas-aeschlimann Thanks for your reply. I must have overlooked your email (still can't find it though), sorry for that. I added you as a collaborator to this repo. Is this sufficient for you to continue?
Don't worry, it wasn't that important (logs say it was on Mar 23, 23:51).
Thank you for your quick reply. If @rafa-as wants to help, maybe you can add him as well?
The only question that remains is how we are going to publish it. If we want to continue to use the current NPM repository, you would need to give us access there as well (it seems to be simple and possible on a per-repo basis). Otherwise we would need to start a fork.
@andreas-aeschlimann Thanks for your reply. I must have overlooked your email (still can't find it though), sorry for that. I added you as a collaborator to this repo. Is this sufficient for you to continue?
Don't worry, it wasn't that important (logs say it was on Mar 23, 23:51).
Thank you for your quick reply. If @rafa-as wants to help, maybe you can add him as well?
The only question that remains is how we are going to publish it. If we want to continue to use the current NPM repository, you would need to give us access there as well (it seems to be simple and possible on a per-repo basis). Otherwise we would need to start a fork.
@andreas-aeschlimann I have npm permissions to publish new versions ;)
@andreas-aeschlimann Thanks for your reply. I must have overlooked your email (still can't find it though), sorry for that. I added you as a collaborator to this repo. Is this sufficient for you to continue?
Don't worry, it wasn't that important (logs say it was on Mar 23, 23:51). Thank you for your quick reply. If @rafa-as wants to help, maybe you can add him as well? The only question that remains is how we are going to publish it. If we want to continue to use the current NPM repository, you would need to give us access there as well (it seems to be simple and possible on a per-repo basis). Otherwise we would need to start a fork.
@andreas-aeschlimann I have npm permissions to publish new versions ;)
Ah, great. I think the most important thing is that we have a release for each Angular version (if necessary). I'll be available if you need support.
Hey all. Can we merge and publish this to npm? Looks like the PR is ready
Hey all. Can we merge and publish this to npm? Looks like the PR is ready
Yes please! Would greatly appreciate it @rafa-as
@rafa-as Is there any timeline for merging this PR? It would be immensely helpful!
@rafa-as, is there a specific reason why we are waiting with the update? I would do it, unfortunately I only received permissions for this repo and not for NPM. We should really publish the update, Angular 14 is already out as well.
@andreas-aeschlimann You now have NPM access to publish versions. This should allow you and all those who are waiting for this PR to move on :)
@andreas-aeschlimann @rafa-as I think many would appreciate an answer ;)
@nicky-lenaers in case of no response, should someone else take over, including going through open issues and clean things up?
To @TheDelta and the others, I'm so sorry about the silence, for personal reasons I couldn't resolve this PR and the other issues. We are working to finally merge this PR, publish the version and create a new PR for the v14 version, the last one supporting non-ivy compilations.
Thanks for your patience!
To @TheDelta and the others, I'm so sorry about the silence, for personal reasons I couldn't resolve this PR and the other issues. We are working to finally merge this PR, publish the version and create a new PR for the v14 version, the last one supporting non-ivy compilations.
Thanks for your patience!
Thanks @rafa-as. Is it just a matter of merging and publishing, or is there still work to do? As I have been added to this repo just recently, I didn't want to go ahead and do it without your feedback. I would happily do it if I got the "clearance" from you guys.