Nicolas Stalder

Specific to your alternative PR, we had a lot more generic parameters in the past and got rid of them. E.g., code like ``` impl

Yes, a Config trait might work for some use cases too. The overarching message I'm trying to send is to keep the overall generic count in any given part of...

Interesting choice of API, I like it! I was previously thinking of something along the lines of https://doc.rust-lang.org/std/io/trait.Read.html#method.read_vectored (to have precedent), that is, passing a slice of slices. There is...

The `CONTROL_BUF_LEN` could/should then also be set to optimal size, current setting at 128 bytes is too small for big descriptors.

Before the compile time descriptors happen, maybe https://github.com/jamesmunns/mcf-config-demo could be a nice approach to configure `CONTROL_BUF_LEN` (and possibly other things). What do you think?

Yes, that's the whole idea of the trick: A "config file" crate that has sane defaults, but can be patched out via Cargo by the user of `usb-device`. If you...

I think the current buzzword is configfs, https://elinux.org/images/e/ef/USB_Gadget_Configfs_API_0.pdf Besides, the worse the API, the more of an improvement a nice Rust API can make :)

A bit independent of your comments, it might be better to trigger the grease behaviour via `--cfg` flags instead of (negative) feature flags (unless it actually becomes some kind of...

I've started to fix this: https://github.com/nickray/littlefs2/pull/6 I think the UB issues can be summed up with: Use closures to do cleanup (closing files/readdirs) with error reporting. Will test against my...

@japaric I believe these issues are all prevented/solved in https://github.com/nickray/littlefs2/pull/6. > As an additional note: is one allowed to modify the directory structure (e.g. > call `Filesystem::remove`) while iterating it...