tdmpc2 icon indicating copy to clipboard operation
tdmpc2 copied to clipboard

data loading typo

Open quantumiracle opened this issue 1 year ago • 1 comments
trafficstars

Hi, this line should be:

assert self.buffer.num_eps == (self.buffer.capacity // _cfg.episode_length), \
	f'Buffer has {self.buffer.num_eps} episodes, expected {self.buffer.capacity // _cfg.episode_length} episodes.'

quantumiracle avatar Apr 17 '24 19:04 quantumiracle

Great catch! This seems to be a leftover from the previous buffer implementation (pre commit https://github.com/nicklashansen/tdmpc2/commit/54145a4d8c4c080836ff1f186fc5a87f70c8a8c7). I'll fix this soon and double-check that everything else in the offline trainer works as expected.

nicklashansen avatar Apr 20 '24 17:04 nicklashansen

Closing this issue since it was fixed a while ago. Thanks again for reporting it!

nicklashansen avatar Dec 11 '24 00:12 nicklashansen