ansible-acme-sh

ansible-acme-sh copied to clipboard

Hi,

This is a small pull request to add the ability to your role to call deploy hook from acme (https://github.com/acmesh-official/acme.sh/wiki/deployhooks).

I'll be glad to discuss about this PR if needed

Regards

Hi, thanks for the PR.

This isn't a feature I've used personally. What platforms have you tested this on?

Hi, thanks for the PR.

This isn't a feature I've used personally. What platforms have you tested this on?

You're welcome, I'll update soon this PR with small improvements and fixing regarding you're comments. This feature is already provided by Acme.sh himself so it should work everywhere but in my case I'm doing my test on Debian 10 / 9.

Is there a case to be made to include a default deploy_hook which does nothing by default but is defined and available to be overwritten like some of the other vars that have defaults?

For example, would you ever want to use the same deploy hook for multiple projects?

Is there a case to be made to include a default deploy_hook which does nothing by default but is defined and available to be overwritten like some of the other vars that have defaults?

For example, would you ever want to use the same deploy hook for multiple projects?

Yes I forgot to add this capability, but it can be useful to have a default hook value to avoid defining the deploy hook for each domains and only override it only when necessary.

I'll add and empty default value et update the PR.

Thanks.

Can you roll all of this up into 1 commit with a message of "Add deploy hook feature" after addressing the last review and example docs request.

Can you also add a working example in the docs at the end of the other examples?

One that goes over configuring a specific hook for a domain (not using the default)?

Hi @nickjj ,

Hope this time everything is OK ;-)