NodaTimePicker icon indicating copy to clipboard operation
NodaTimePicker copied to clipboard

Published 20 hours ago • verified publisher icon nheath99

Ability to choose calendar system other that Iso + Enhanced culture info + fixed bugs

Open ysmoradi opened this issue 5 years ago • 3 comments

Thanks for your fantastic library

ysmoradi avatar Aug 17 '20 09:08 ysmoradi

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 17 '20 09:08 sonarqubecloud[bot]

Hi, thanks for the interest in the package! I'm interested to know what the purpose of the first two commits (https://github.com/nheath99/NodaTimePicker/pull/103/commits/d52313d99d4f4675405da05a43c8ce34daed1707 and https://github.com/nheath99/NodaTimePicker/pull/103/commits/be1dcb078903c940aa1d2e491453cb7d1881b89b)? Could you provide some context? It seems that there is a combination of new features, bug fixes, and formatting changes.

nheath99 avatar Aug 18 '20 20:08 nheath99

YW! I've not applied those changes. I saw those changes in another fork, and I though it's a good idea to have a look at them! If you see no value at the moment in those commits, let's merge the last commit only. The last commit is so handy, because it lets you to use any noda calendar system you prefer to use!

ysmoradi avatar Aug 19 '20 07:08 ysmoradi