draft-js-markdown-shortcuts-plugin

draft-js-markdown-shortcuts-plugin copied to clipboard

Incompatibility with createLinkPlugin

[{"_id":"6346a0b58402fb318b7180ef","body":"I think the problem is the component being rendered is only supplied with `href` and `title`, can the component still take other attributes? target, classes and etc.\r\n\r\nLink for reference\r\nhttps:\/\/github.com\/ngs\/draft-js-markdown-shortcuts-plugin\/blob\/631f1863341ee57cd3cd93c54d06b364562254da\/src\/components\/Link\/index.js","issue_id":1660447700507,"origin_id":787478020,"user_origin_id":12130528,"create_time":1614529381,"update_time":1614529395,"id":1665573045064,"updated_at":"2022-10-12T11:10:45.064000Z","created_at":"2022-10-12T11:10:45.064000Z"}]

I want to be able to use both markdown shortcuts plugin and [draft-js-anchor-plugin](https://www.draft-js-plugins.com/plugin/anchor) but it's impossible to get them to both work in creating a link. I think the problem...

xiaoyunyang

Add typing for export default

[]

Add a very simple types declare for user import modules when on TypeScript project

demongodYY

Replace onTab for keyBindingFn

[{"_id":"6346a063cd14df15ba5d37ed","body":"I am not sure what the test failure indicates. Is this hard to fix? I would really like to get rid of the warning in my console..","issue_id":1660447700513,"origin_id":737050703,"user_origin_id":847742,"create_time":1606894452,"update_time":1606894452,"id":1665572963143,"updated_at":"2022-10-12T11:09:23.142000Z","created_at":"2022-10-12T11:09:23.142000Z"},{"_id":"6346a063cd14df15ba5d37ee","body":"@kristiandupont The error in the test is due to my lack of permissions in the repository. I hope the author has time to take a look. \ud83e\udd14","issue_id":1660447700513,"origin_id":738446194,"user_origin_id":31826994,"create_time":1607037477,"update_time":1607037477,"id":1665572963147,"updated_at":"2022-10-12T11:09:23.146000Z","created_at":"2022-10-12T11:09:23.146000Z"},{"_id":"6346a063cd14df15ba5d37ef","body":"@ngs sorry to bother you, just wondering if this might be simple to merge? ","issue_id":1660447700513,"origin_id":743084109,"user_origin_id":847742,"create_time":1607679129,"update_time":1607679129,"id":1665572963150,"updated_at":"2022-10-12T11:09:23.150000Z","created_at":"2022-10-12T11:09:23.150000Z"}]

· Solves onTab warnings. onTab is deprecated and after key pressing it, it doesn't indent the text. · Solves line indention on selecting text adding spaces at the start of...

erikmartinjordan

keyBindingFn not triggering on tab key press

[]

Inlcuding the `draft-js-markdown-shortcuts-plugin` is blocking key binding for the tab key. Example: ```jsx const keyDown = (e) => { if(e.key === 'Tab'){ console.log('I never get here...'); } console.log('Other keys are...

erikmartinjordan

Link within existing text removes rest of line.

[]

Hello, using 0.6.1, I can repro this on the demo page as well. Adding markdown for a link removes any trailing characters in the rest of the line. For example,...

Jtfinlay

How to init with pre content?

[{"_id":"6346ad6d8402fb318b718950","body":"Import the following\r\n\r\n~~~\r\nimport { EditorState, ContentState } from 'draft-js';\r\n~~~\r\n\r\nAfter that, you can set the content in a constructor (or differently) by:\r\n~~~\r\nthis.state = {\r\n editorState: EditorState.createWithContent(ContentState.createFromText(\"hello\"))\r\n};\r\n~~~\r\n\r\nHowever, adding markdown text in the `createFromText` function doesn't trigger parsing from the plugin, which I would love the developer to document or chime in on.","issue_id":1660447700524,"origin_id":515512384,"user_origin_id":22320876,"create_time":1564157505,"update_time":1564157505,"id":1665576301926,"updated_at":"2022-10-12T12:05:01.926000Z","created_at":"2022-10-12T12:05:01.926000Z"},{"_id":"6346ad6d8402fb318b718951","body":"Found a solution to problem specified above:\r\n\r\nInstall \r\n~~~\r\nnpm install --save draft-js-import-markdown\r\n~~~\r\n\r\nThen you can set the content state as such:\r\n~~~\r\nthis.state = {\r\n editorState: EditorState.createWithContent(stateFromMarkdown(\"#markdowntitle\"))\r\n};\r\n~~~","issue_id":1660447700524,"origin_id":515516044,"user_origin_id":22320876,"create_time":1564158229,"update_time":1564158229,"id":1665576301954,"updated_at":"2022-10-12T12:05:01.954000Z","created_at":"2022-10-12T12:05:01.954000Z"}]

As the question

zfha

Bullet Shortcut does not erase placeholder

[]

**Expected Behavior** If you have `placeholder` specified as a prop for the `Editor` and you use the markdown shortcuts to create a bullet, the placeholder should not be displayed. **Actual...

xiaoyunyang

Breaks on latest Draft-JS-Plugins release :( (getEditorState is not a function)

[{"_id":"6346a6996a9f94608c599b39","body":"@Discordius \r\nPlease try this quick fix on `index.js`.\r\n\r\n```diff\r\n- handleReturn(ev, { getEditorState, setEditorState }) {\r\n+ handleReturn(ev, editorState, { setEditorState }) {\r\n\r\n- handleBeforeInput(character, { getEditorState, setEditorState }) {\r\n+ handleBeforeInput(character, editorState, { setEditorState }) {\r\n```\r\n\r\n(the latest draft-js-plugins is in the release candidate stage yet, so I'd like to create PR if this repository has an v2.0.0 branch)","issue_id":1660447700528,"origin_id":304496726,"user_origin_id":1843532,"create_time":1495954129,"update_time":1495954129,"id":1665574554000,"updated_at":"2022-10-12T11:35:54.000000Z","created_at":"2022-10-12T11:35:54.000000Z"},{"_id":"6346a69a6a9f94608c599b3a","body":"I ran into this as well. PR was merged (#26) but is probably not on NPM as of this comment.","issue_id":1660447700528,"origin_id":306116623,"user_origin_id":3154865,"create_time":1496645485,"update_time":1496645485,"id":1665574554005,"updated_at":"2022-10-12T11:35:54.004000Z","created_at":"2022-10-12T11:35:54.004000Z"},{"_id":"6346a69a6a9f94608c599b3b","body":"Since 0.3.0 this _should_ hopefully no longer be an issue. @ngs this can probably be closed out","issue_id":1660447700528,"origin_id":311128648,"user_origin_id":3154865,"create_time":1498498518,"update_time":1498498518,"id":1665574554008,"updated_at":"2022-10-12T11:35:54.008000Z","created_at":"2022-10-12T11:35:54.008000Z"},{"_id":"6346a69a6a9f94608c599b3c","body":"I have the same problem here https:\/\/github.com\/facebook\/draft-js\/issues\/473#issuecomment-373791338","issue_id":1660447700528,"origin_id":375020284,"user_origin_id":4691768,"create_time":1521651982,"update_time":1521651982,"id":1665574554012,"updated_at":"2022-10-12T11:35:54.011000Z","created_at":"2022-10-12T11:35:54.011000Z"}]

Alas, looks like this broke with the release of the latest two versions of draft-js-plugins. Since those fix some super important bugs for me, it would be great if one...

Discordius

Newline doesn't trigger expansion

[{"_id":"6346a8f409a35269b781dbac","body":"I am facing the same issue. Strangely, it works fine in the demo.","issue_id":1660447700531,"origin_id":355954481,"user_origin_id":806749,"create_time":1515414686,"update_time":1515414686,"id":1665575156719,"updated_at":"2022-10-12T11:45:56.719000Z","created_at":"2022-10-12T11:45:56.719000Z"}]

Behavior observed on the public demo. Entering a newline does not trigger expansion like hitting space does. Example: input: ``` text *highlight* text ``` produces: text *highlight* text (note that...

seanmiddleditch

Undo markdown

[]

Most other editors have a function where if you hit (⌘ + Z / Ctrl + Z) it will undo the automarkdown, and leave the text as it was. Eg....

oscarmorrison