contributor-faces icon indicating copy to clipboard operation
contributor-faces copied to clipboard

Ehancements

Open benallfree opened this issue 5 years ago • 1 comments

Hi, I made some enhancements that I thought you might want. Basically my use case was to allow for multiple face lists based on various criteria and filters.

The main change I made looks like this:

function core(dir, opts) {
  opts = {
    dir: '.',
    limit: 1000,
    size: 40,
    prefix: 'contributor',
    linkTo: (contributor) => contributor.html_url,
    avatarUrl: (contributor) => contributor.avatar_url,
    imageTitle: (contributor) => contributor.login,
    filter: (contributors) => contributors,
    ...opts,
  }
  return Promise.resolve(opts).then(getRepo).then(fetch).then(filter)
}

And of course there are corresponding changes throughout the code to support it. Are you interested in an enhancement like this?

benallfree avatar Sep 13 '20 20:09 benallfree

Hey @benallfree,

I like the idea of having multiple lists. However, I would like to keep this tool as simple as possible, mainly to keep its maintenance cost low. Do you have an existing fork so I could take a look at the changes it would involve?

Thanks!

ngryman avatar Oct 14 '20 16:10 ngryman