platform
platform copied to clipboard
fix(component-store): make synchronous updater errors catchable
PR Checklist
Please check if your PR fulfills the following requirements:
- [x] The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Documentation has been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?
Closes #3266
What is the new behavior?
All synchronous errors are now catchable. Also, error handling is changed - an error will not be emitted to the stateSubject$ anymore, it will be thrown instead.
Does this PR introduce a breaking change?
[ ] Yes
[x] No
As we discussed at the last team meeting, this should not be considered a breaking change.
Deploy Preview for ngrx-io canceled.
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | c3b3e002a78b045375db913b0f4835907517aacb |
| Latest deploy log | https://app.netlify.com/sites/ngrx-io/deploys/62e1a09ed51c630009a3db72 |