talk-android icon indicating copy to clipboard operation
talk-android copied to clipboard

Feature/1530/share android screen

Open mahibi opened this issue 4 years ago • 9 comments

this is just a proof of concept for https://github.com/nextcloud/talk-android/issues/1530 to show that sharing the Android Screen is possible.

Please note that this is very quick and dirty and breaks other features atm!!! basically video from camera was replaced by screen stream, so to test just make a videocall..

Work on screen sharing is paused indefinitely

mahibi avatar Aug 31 '21 08:08 mahibi

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/1562-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

github-actions[bot] avatar Aug 31 '21 08:08 github-actions[bot]

Lint

TypemasterPR
Warnings269271
Errors33

SpotBugs (new)

Warning Type Number
Bad practice Warnings 12
Correctness Warnings 140
Experimental Warnings 2
Internationalization Warnings 9
Malicious code vulnerability Warnings 168
Performance Warnings 40
Security Warnings 4
Dodgy code Warnings 227
Total 602

SpotBugs (master)

Warning Type Number
Bad practice Warnings 12
Correctness Warnings 139
Experimental Warnings 2
Internationalization Warnings 9
Malicious code vulnerability Warnings 168
Performance Warnings 39
Security Warnings 4
Dodgy code Warnings 227
Total 600

Lint increased!

SpotBugs increased!

nextcloud-android-bot avatar Aug 31 '21 09:08 nextcloud-android-bot

Is there any new work being done here?

abdusalamApps avatar Apr 09 '23 20:04 abdusalamApps

Is there any new work being done here?

No new work was done here but it's a feature that might be added to the roadmap for the next versions

mahibi avatar Apr 17 '23 12:04 mahibi

Is there any new work being done here?

No new work was done here but it's a feature that might be added to the roadmap for the next versions

Thanks for the reply. I would be more than glad to help with implementing it. I actually I tried, but I didn't know where to start! Any ideas or tips?

abdusalamApps avatar Apr 21 '23 15:04 abdusalamApps

Is there any new work being done here?

No new work was done here but it's a feature that might be added to the roadmap for the next versions

Thanks for the reply. I would be more than glad to help with implementing it. I actually I tried, but I didn't know where to start! Any ideas or tips?

thank you for the offer to help :+1: For lack of time i can't provide more specific instructions than having a look at this PR, sorry. UI-wise i would begin with adding an option to the "more options" button.

mahibi avatar Apr 21 '23 15:04 mahibi

Is there any new work being done here?

No new work was done here but it's a feature that might be added to the roadmap for the next versions

Thanks for the reply. I would be more than glad to help with implementing it. I actually I tried, but I didn't know where to start! Any ideas or tips?

thank you for the offer to help +1 For lack of time i can't provide more specific instructions than having a look at this PR, sorry. UI-wise i would begin with adding an option to the "more options" button.

My pleasure. I'll see what I can do, but I'll create a new branch from latest master, because I noticed that the code has changed considerably since this PR was created. So it would a clean start.

abdusalamApps avatar Apr 21 '23 16:04 abdusalamApps

I would really be happy if this feature would not be set to ice. Goto Webinar, Goto Meeting, Teams,... many more already support screenshare. I wanna use my phone for presentations in Samsung Dex and with this feature I could replace my presentation pc.

GVLLIFESTYLE avatar Nov 21 '23 10:11 GVLLIFESTYLE

I would really be happy if this feature would not be set to ice. Goto Webinar, Goto Meeting, Teams,... many more already support screenshare. I wanna use my phone for presentations in Samsung Dex and with this feature I could replace my presentation pc.

GVLLIFESTYLE avatar Nov 21 '23 10:11 GVLLIFESTYLE