server icon indicating copy to clipboard operation
server copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud

Update via UI breaks with future version of symfony/event-dispatcher

Open nickvergessen opened this issue 3 years ago • 0 comments
trafficstars 

TypeError: Symfony\\Component\\EventDispatcher\\GenericEvent::getArgument(): Argument #1 ($key) must be of type string, int given, called in /var/www/nextcloud/server/lib/private/EventDispatcher/GenericEventWrapper.php on line 81 at /var/www/nextcloud/server/appsbabies/spreed/vendor/symfony/event-dispatcher/GenericEvent.php#60

We have several events which use int based arrays for the arguments:

  • [ ] lib/private/DB/Migrator.php https://github.com/nextcloud/server/blob/215aef3cbdc1963be1bb6bca5218ee0a4b7f1665/lib/private/DB/Migrator.php#L204
  • [ ] lib/private/Repair.php https://github.com/nextcloud/server/blob/9a9409e31583c0fdd7c0bfe67f5f9177c7651830/lib/private/Repair.php#L255-L260

We can adjust them already now to have string based arguments which is a much better description.

nickvergessen avatar Jul 18 '22 14:07 nickvergessen