news-android

news-android copied to clipboard

As there is a swipe shortcut by default for marking something as a favourite, it makes zero sense to me why I can't hide the unilluminated star button on each news item. It makes your entire feed look as if it is full of favourites, especially so for colour-blind users.

As there is a swipe shortcut by default for marking something as a favourite, it makes zero sense to me why I can't hide the unilluminated star button on each news item.

Well, gestures are usually hard to discover as they are not directly visible. Also without the button the current state is not discoverable (even though it can be changed). Compared to the read / unread state which marks the text as normal / bold. So a button makes sense to me.

Color blindness is an interesting accessibility issue though which we haven't thought about yet. The files app doesn't have the issue as it only displays the stars when starres, but for files it is also a secondary feature, while it is essential for news. This issue reminded me that we have the same problem in the Notes Android app.

Maybe the best of both worlds is to add another factor beside the color to make the star distinguishable: Form. Throwing in two ideas:

cc @nextcloud/designers

@HammyHavoc Which feed list layout are you using? The new Thumbnails (only Headlines) layout which is also default now does not have the unilluminated star anymore. (You can change it in the Apps settings under "Feed list layout")

I like your first idea stefan (filled / unfilled star) - makes it clearer 👍. I'm not sure why but the strikethrough doesn't feel natural to me and I wouldn't feel 100% clear about the meaning if I saw it in an app.