maps

maps copied to clipboard

Please add compatibility for Nextcloud 31.

With all due respect, bumping issues is considered harmful.

This is only causing notification spam for people like me who subscribed the issue to get updates on that matter.

Is it known to be broken with 31, or is it just not tested?

Is it known to be broken with 31, or is it just not tested?

I just did a short test which looked good so far. This is with nc 31.0.1. So, it should be easy to add compatibility with nc 31.

Is it known to be broken with 31, or is it just not tested?

I just did a short test which looked good so far. This is with nc 31.0.1. So, it should be easy to add compatibility with nc 31.

That's at least good to know. I'm going to stick with NC 30 until this is updated, but hopefully @tacruc or someone else can let us know if they have an update soon or recommend upgrading even though it is untested.

Is there an update on the support for NC31 or what needs to be done?

Is there an update on the support for NC31 or what needs to be done?

I think a new version is on its way, see the latest commits.

There is a nightly release, haven't had time to do much testing. Feel free to provide feedback. If it is similarly stable as the other versions we can publish it.

Since there is still min-version="30" declared I wanted to upgrade the app to 1.6.0-3-nightly first to avoid disabling the app before upgrading to NC31; unfortunately that did not go well and the whole site is broken:

{"reqId":"AXdljMBQLwsomJOgc2Bv","level":3,"time":"2025-05-08T04:30:42+00:00","remoteAddr":"<myip-redacted>","user":"--","app":"index","method":"GET","url":"/index.php/204","message":"Backends provided no user object","userAgent":"Mozilla/5.0 (Linux) mirall/3.16.2-1 (Debian built) (Nextcloud, debian-6.12.25-amd64 ClientArchitecture: x86_64 OsArchitecture: x86_64)","version":"30.0.10.1","exception":{"Exception":"OC\\User\\NoUserException","Message":"Backends provided no user object","Code":0,"Trace":[{"function":"getUserFolder","class":"OC\\Files\\Node\\Root","type":"->","args":["duck-atlas"]},{"file":"/srv/www/sites/stuff.milkypond.org/nextcloud-30.0.10/lib/private/Files/Node/LazyFolder.php","line":64,"function":"call_user_func_array","args":[[{"__class__":"OC\\Files\\Node\\Root"},"getUserFolder"],["duck-atlas"]]},{"file":"/srv/www/sites/stuff.milkypond.org/nextcloud-30.0.10/lib/private/Files/Node/LazyRoot.php","line":38,"function":"__call","class":"OC\\Files\\Node\\LazyFolder","type":"->","args":["getUserFolder",["duck-atlas"]]},{"file":"/usr/local/share/stuffcloud/apps/notes/lib/Service/NoteUtil.php","line":188,"function":"getUserFolder","class":"OC\\Files\\Node\\LazyRoot","type":"->","args":["duck-atlas"]},{"file":"/usr/local/share/stuffcloud/apps/notes/lib/AppInfo/Capabilities.php","line":29,"function":"getNotesFolderUserPath","class":"OCA\\Notes\\Service\\NoteUtil","type":"->","args":["duck-atlas"]},{"file":"/srv/www/sites/stuff.milkypond.org/nextcloud-30.0.10/lib/private/CapabilitiesManager.php","line":61,"function":"getCapabilities","class":"OCA\\Notes\\AppInfo\\Capabilities","type":"->","args":[]},{"file":"/srv/www/sites/stuff.milkypond.org/nextcloud-30.0.10/lib/private/Template/JSConfigHelper.php","line":135,"function":"getCapabilities","class":"OC\\CapabilitiesManager","type":"->","args":[false,true]},{"file":"/srv/www/sites/stuff.milkypond.org/nextcloud-30.0.10/lib/private/TemplateLayout.php","line":230,"function":"getConfig","class":"OC\\Template\\JSConfigHelper","type":"->","args":[]},{"file":"/srv/www/sites/stuff.milkypond.org/nextcloud-30.0.10/lib/private/legacy/OC_Template.php","line":119,"function":"__construct","class":"OC\\TemplateLayout","type":"->","args":["guest",""]},{"file":"/srv/www/sites/stuff.milkypond.org/nextcloud-30.0.10/lib/private/Template/Base.php","line":113,"function":"fetchPage","class":"OC_Template","type":"->","args":[]},{"file":"/srv/www/sites/stuff.milkypond.org/nextcloud-30.0.10/lib/base.php","line":307,"function":"printPage","class":"OC\\Template\\Base","type":"->","args":[]},{"file":"/srv/www/sites/stuff.milkypond.org/nextcloud-30.0.10/lib/base.php","line":975,"function":"printUpgradePage","class":"OC","type":"::","args":[{"__class__":"OC\\SystemConfig"}]},{"file":"/srv/www/sites/stuff.milkypond.org/nextcloud-30.0.10/index.php","line":24,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/srv/www/sites/stuff.milkypond.org/nextcloud-30.0.10/lib/private/Files/Node/Root.php","Line":345,"message":"Backends provided no user object","exception":{},"CustomMessage":"Backends provided no user object"}}

I switched back to the old version (1.5.0) and it is working again.

Nightly 1.6.0.3 is working nicely for me in NC30 and NC31.

Update process was:

• Make a copy of maps folder in apps/ folder (just in case i would need to revert update) ~/nextcloud/apps$ tar -czvf maps_1.5_backup.tgz maps
• Delete old maps folder ~/nextcloud/apps$ rm -rf maps
• Unpack nightly in maps / tar -xvzf /tmp/maps-1.6.0-3-nightly.tar.gz -C ~/nextcloud/apps
• Ensure permissions are OK (I did everything as webserver user so I didn't need to change anything)
• Run upgrade occ upgrade

After that I upgraded to NC31 and everything works as expected

There is a nightly release, haven't had time to do much testing. Feel free to provide feedback. If it is similarly stable as the other versions we can publish it.

...but wait: There's atleast one old (nc30) and one new issue (nc31 + PHP8.4) with geotagged images not showing up, not getting updated or excluded from scanning under varying conditions. I'm on the way to patch this (some work is already contained in the current nightly), but not earlier than next week.

Please test & comment: https://github.com/nextcloud/maps/pull/1419 https://github.com/nextcloud/maps/pull/1420 https://github.com/nextcloud/maps/pull/1371

Newly added pictures are processed async in a background-task, thus do not appear immediately, but after next background (cron-)run.

For those not seeing picture-previews especially on newly created installations take a look here: https://github.com/nextcloud/server/pull/52946

@umgfoin Do you have time and feel fine to make a release PR. See https://github.com/nextcloud/maps/pull/1346 for a template. Just ignore the code changes? Maybe a new nightly first and then end of the week stable?

@tacruc,

I'll try to find some time to start a release PR for nc/maps, next week. Looking at your profile picture, I suspect that you might struggle with a similar optimization problem: Dev-time required for these projects is in direct competition with time spent on projects generating the data served ...

• Primary goal: releasing a nc31/php8.4 compatible build ignoring the fact that accumulated changes in both server-API and maps are presumably largely untested for maps? Guess, there won't be much feedback if people can't use it on the latest "stable" NC. I don't see much activity, here, but do you have experience, if nightly builds are downloaded/ tested by a larger audience?

• Is it advisable to pull in pending automatic PRs (deps etc.), first or better to release a snapshot of current master?

• Are there other PRs that should be included?

I've been using current master for a while on NC30/PHP8.4[sic], NC31/PHP8.4 in an "episode-style" test-approach, but far from having maps full feature set in every day usage.

How is the progress on making maps NC31 "ready"?

I run 1.6.0-3-nightly on NC31 for some weeks and did not encounter any problems. I don't use maps on a daily basis though.

At this rate we probably have NC32 before maps gets a compatibility release for NC31 … :-)

At this rate we probably have NC32 before maps gets a compatibility release for NC31 … :-)

Well, if it isn't ready it isn't ready. I'll stay on NC30 until Maps is ready or NC30 is out of support; if NC30 goes out of support first, I'll ditch Maps until it's ready.

NC 30 is EOL on September 30. Not that far away.

You guys are complaining, but when the dev asked for some testing, none of you is helping ..

You guys are complaining, but when the dev asked for some testing, none of you is helping ..

Wow, a fair bit to unpack there. I can only speak for my own situation, of course.

First, I wasn't complaining. I was simply describing my intended course of action. Maps is important enough to me to hold back my Nextcloud upgrade, but not important enough to remain on an unsupported version.

Second, and perhaps way more important, I don't have a test system on which to perform tests. I only have my production system, which is the reason that I'm intending to take my planned course of action. Even if I did have a test system, I haven't seen any indication regarding what needs testing.

@Justinzobel

NC 30 is EOL on September 30. Not that far away.

How is the progress on making maps NC31 "ready"?

@ppfeufer

At this rate we probably have NC32 before maps gets a compatibility release for NC31 … :-)

Aye Sirs, concerning speed & other people's progress, kindly turn your attention at PRs.

But how about you? Found any time for testing master or nightlies? We have already ONE feedback, here! Can't beat the feeling, consumer /-tributor ratio has a significant bias for this project.

Heard it throug the grapewine, basic support for instant free lunch will not come with maps 1.7, either, beside YOU prepare it.

I think this is a difference of opinion what complaining is.

My understanding of complaining would be a comment like these:

• "Why is this not ready yet?"
• "How long is this taking?!"
• "This is unacceptable, this should have been made ready at the release of Nextcloud 30"
• "For $#@$ sake, why is this taking so long?"

While I think some comments on this issue could be more respectful, I think nobody has "complained". Most commenters have just asked for updates at respectful intervals.

May I politely ask what needs to be tested exactly?

Changelog lists: https://github.com/nextcloud/maps/blob/master/CHANGELOG.md#160---unreleased-nextcloud-hub-10

In addition I found this commit removing cache usage: https://github.com/nextcloud/maps/commit/983a42140eafe92562c57c486063d1494f21b184

And this issue resolving problems with public pages: https://github.com/nextcloud/maps/pull/1363

Other commits are either related to those above, dependancy chores or linting/code "beautification".

With my instance lacking external storage or public pages to test against, cache removal not being clear at what would be possible to break, and Maps generally running fine, so probably no dependency breaks, only thing left to test seems to be scanning specific directory.

Is that correct?

And generally if someone wants to report on quality of changes they'd need to test:

• Georeferenced photos from external folders not shown on map
• Tiles not working on public pages
• Scan photos of specific directory
• General Maps usage

And there's AI/Copilot finding a bug last week...

Did I miss any blockers that would.prevent the release? I mean, there will always be new dependency updates, and no one can ever guarantee code is 100%... But I honestly didn't see any hard blockers either.

In my limited testing I had no issues with Maps on NC 31 (or 30 before that, though that lasted only few hours of use before updating to 31).

If we are given some guidelines what to test, or.if you just need like 10 people to react, please say so. From my own experience, people don't go to these kinds of threads reporting "all good". They pop a thumb up, and will only report if they DO HAVE an issue. So mostly silence for few.months since last release would mean people are ok with it, right?

Thanks for.your time btw, and looking forward to official stable release 👍

Testing out maps-1.6.0-3-nightly with NC 31.0.7, the UI seems to be working at least as well as it was with NC 30 & Maps 1.5.

Re https://github.com/nextcloud/maps/pull/1419:

occ maps:scan-photos fails with a ArgumentCountError: Too few arguments to function OCA\Maps\Command\RescanPhotos::OCA\Maps\Command\{closure}() [snip] unless I provide at least one arg, e.g. an login name, otherwise it seems to work fine.

The --help for that command indicates that the user name is optional, if that is meant to be the case then something needs fixing, but also if it isn't optional, the help text should be updated and that should be checked for an a more useful error message printed instead of the exception.

The other two OCC commands (maps:scan-tracks, maps:register-mimetypes) run fine.

Can't test https://github.com/nextcloud/maps/pull/1420 and https://github.com/nextcloud/maps/pull/1371 since I don't have any external folders or images shared with me.

occ maps:scan-photos fails with a ArgumentCountError: Too few arguments to function

Hello @mjog, thanks for testing!

This is the problem that #1419 fixes - build 1.6.0.3 dates earlier than commit #1419, so it was not part of this release, yet. ++umgfoin.

@umgfoin oh, should have checked, sorry. Happy to keep on testing if a new dev release can be cut, unfortunately I don't have the setup to build it from git myself.

NC31 + PHP 8.4 support is now available with rel 1.6.0 (https://github.com/nextcloud/maps/pull/1431).