helm icon indicating copy to clipboard operation
helm copied to clipboard

Feature: Add persistence settings for redis

Open f3k-freek opened this issue 2 years ago • 2 comments

Description of the change

Add persistence settings for the redis database. Such as storageClass and wether it should be enabled at all.

Benefits

  • It would be possible to use a different storageClass than default which would enable:
    • different type of storage
    • different backup settings
    • etcetera
  • It would be possible to disable persistent storage. Since redis is only used as cache. One might opt to not use persistent storage at all.

Possible drawbacks

  • I can't think of any.

f3k-freek avatar Mar 28 '24 09:03 f3k-freek

Thanks for submitting a feature request :)

You can use any persistence settings you find the bitnami docs here: https://github.com/bitnami/charts/tree/main/bitnami/redis

The way the helm chart works, the bitnami redis helm chart is a subchart, so we pass through anything under the redis parameter in the values.yaml through to that chart. If you'd like, you can submit a PR to add those settings to our values.yaml just so that people are aware of them. If you do, please remember to bump the chart version and update the README in the charts/nextcloud directory, so that everyone can benefit.

jessebot avatar Mar 29 '24 09:03 jessebot

Thank you for your fast reply. I have submitted a PR as you proposed: https://github.com/nextcloud/helm/pull/549

f3k-freek avatar Apr 01 '24 15:04 f3k-freek