deck

deck copied to clipboard

• Resolves: #5406
• Target version: main

Summary

introduces two new filters. done filter: shows only cards that are done on the board open filter: shows only cards that are open on the board

Screenshot:

Checklist

• [ ] Code is properly formatted
• [ ] Sign-off message is added to all commits
• [ ] Tests (unit, integration, api and/or acceptance) are included
• [ ] Documentation (manuals or wiki) has been updated or is not required

Would you mind adding a screenshot for easier review? 🙂

Thank you very much, that's pretty much what I expected it from a look into the source code.

But the approach with the radio buttons has one issue: Once set, only all filter can be cleared.

Therefore two UX questions:

1. Is filtering for Done actually necessary? If not we could simply go for one checkbox or switch Hide done
2. If it is absolutely necessary, maybe a toggle button group of three buttons would make sense? Undone | All | Done

Personally I also would merge it with the due date section as these information play together, also in the cards themself.

Last not least; Wording. In the cards itself the action is called Completed, it should be the same everywhere. Mixing up the terms Completed and Done is confusing.

Thanks for the contribution. The wording is indeed not 100% consistent also in the existing code base, I'd settle on "Completed" and "Not completed".

Is filtering for Done actually necessary? If not we could simply go for one checkbox or switch Hide done

I'd say showing all, completed, uncompleted is still usful, so a threeway option sounds good 👍

@grnd-alt Could you adapt that and also check the failing eslint job and DCO Then this seems good to get merged

@juliushaertl By a threeway option, do you mean having three radio buttons like the existing ones? Or rather having a new type of filter option with multiple buttons in one row?

By a threeway option, do you mean having three radio buttons like the existing ones?

I think for the matter of this PR this is the most sensible option.

Or rather having a new type of filter option with multiple buttons in one row?

This sounds like generally a nicer idea but the best way to implement this might be to migrate the full menu to the NcActions component and then use NcActionButtonGroup/NcActionCheckbox/NcActionRadio for the list entries. So if you're eager feel free to dive into that but I would not consider that required for the scope of this issue for now.

Ok, great! I'll finish this PR up, and possibly start a refactoring in another PR/issue.

+1

Sorry for the delay on reviewing, will check again today or tomorrow