contacts icon indicating copy to clipboard operation
contacts copied to clipboard

Fix missing strict types for the social service

Open ChristophWurst opened this issue 4 years ago • 3 comments

ChristophWurst avatar Feb 18 '22 16:02 ChristophWurst

I guess we have to convert the http status to string here for unit tests to pass with strict types ... or to integer here?

call-me-matt avatar Feb 18 '22 20:02 call-me-matt

I guess we have to convert the http status to string here for unit tests to pass with strict types ... or to integer here?

It should be an int. Could you fix this please?

ChristophWurst avatar Feb 21 '22 10:02 ChristophWurst

Codecov Report

Base: 31.30% // Head: 69.15% // Increases project coverage by +37.85% :tada:

Coverage data is based on head (0a4ef1b) compared to base (48be4a1). Patch coverage: 66.66% of modified lines in pull request are covered.

:exclamation: Current head 0a4ef1b differs from pull request most recent head 5eab505. Consider uploading reports for the commit 5eab505 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2647       +/-   ##
=============================================
+ Coverage     31.30%   69.15%   +37.85%     
+ Complexity      253      247        -6     
=============================================
  Files           109       21       -88     
  Lines          1853      697     -1156     
  Branches        218        0      -218     
=============================================
- Hits            580      482       -98     
+ Misses         1158      215      -943     
+ Partials        115        0      -115     
Impacted Files Coverage Δ
lib/Service/SocialApiService.php 91.15% <66.66%> (+1.54%) :arrow_up:
lib/Dav/PatchPlugin.php 0.00% <0.00%> (ø)
lib/Cron/SocialUpdate.php 0.00% <0.00%> (ø)
lib/Controller/PageController.php 100.00% <0.00%> (ø)
lib/Cron/SocialUpdateRegistration.php 0.00% <0.00%> (ø)
src/services/checks/duplicateTypes.js
src/views/Processing/AddToGroupView.vue
src/components/Actions/ActionCopyNtoFN.vue
src/components/EntityPicker/ContactsPicker.vue
...c/components/AppNavigation/GroupNavigationItem.vue
... and 84 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Feb 21 '22 19:02 codecov[bot]