tracy icon indicating copy to clipboard operation
tracy copied to clipboard

StreamLogger

Open JanTvrdik opened this issue 7 years ago • 5 comments

  • bug fix? no
  • new feature? yes
  • BC break? no

implements #280

JanTvrdik avatar Feb 22 '18 13:02 JanTvrdik

Isn't better this

Debugger::setLogger(new StreamLogger);
Debugger::enable();

than this?

Debugger::enable(Debugger::DETECT, new StreamLogger);

dg avatar Feb 22 '18 14:02 dg

The issue is that in Nette you're never actually calling Debugger::enable(), because there is $configurator->enableDebugger(). So, the actual comparison is

Tracy\Debugger::setLogger(new Tracy\StreamLogger('php://stderr'));

$configurator = new Nette\Configurator();
$configurator->enableDebugger();

vs.

$configurator = new Nette\Configurator();
$configurator->enableDebugger(new Tracy\StreamLogger('php://stderr'));

JanTvrdik avatar Feb 22 '18 14:02 JanTvrdik

When I think about it now, the logic could be moved to Nette\Configurator – but it would create disparity between Tracy\Debuger::enable() and Nette\Configurator::enableDebugger() signatures.

JanTvrdik avatar Feb 22 '18 14:02 JanTvrdik

create disparity between

It does not matter.

dg avatar Feb 25 '18 16:02 dg

@JanTvrdik Do you want to move it somehow in v2.5? Or deprecate something, so the next version does not have to require a lot of hacks?

dg avatar Apr 06 '18 12:04 dg