forms icon indicating copy to clipboard operation
forms copied to clipboard

Published 20 hours ago • verified publisher icon nette

IControl::setValue() ⇒ setCurrentValues()

Open dg opened this issue 9 years ago • 8 comments

to solve #114

dg avatar Jun 30 '16 12:06 dg

Looks like pointless BC break to me.

JanTvrdik avatar Sep 22 '16 21:09 JanTvrdik

Point https://github.com/nette/forms/issues/114

dg avatar Sep 26 '16 16:09 dg

I never did not fully understand (or remember) difference between setValue and setDefaultValue and I am using it wrong for sure (at least I think). I am totally supporting some kind of change because there would be a lot of similar developers with the same problem as I have... :)

mrtnzlml avatar Sep 26 '16 19:09 mrtnzlml

I'm aware of the point, but I think that the number of people who accidentally use setValue is very low.

JanTvrdik avatar Sep 26 '16 19:09 JanTvrdik

I like an idea (setValue -> setCurrentValue) , but it's inconvenient BC break. Unfortunatelly, I don't see any other way.

f3l1x avatar Jun 18 '17 12:06 f3l1x

Current states confuses people

image

My recommendation is to revert marking setValues / setValue as internal.

JanTvrdik avatar Aug 17 '17 08:08 JanTvrdik

Just yesterday I have encountered the same weid feeling if I'm doing something wrong. (I was not)

hrach avatar Aug 17 '17 08:08 hrach

This is a problem where is no simple and right solution.

dg avatar Aug 17 '17 10:08 dg