database icon indicating copy to clipboard operation
database copied to clipboard

Published 20 hours ago • verified publisher icon nette

Missing `havingOr` ?

Open dakujem opened this issue 5 years ago • 3 comments

I would like to see method Selection::havingOr implemented, as that feature is missing and cumbersome to achieve.

It should work analogously to the Selection::whereOr method.

Let me know if I could work on this. Also, I'd like to port this feature to the 2.x branch.

dakujem avatar Nov 16 '19 19:11 dakujem

Yes, please send PR.

dg avatar Nov 18 '19 20:11 dg

Well I looked into this issue the other day and found out it would require a deeper rework and a BC break without a doubt.

This is because in the SqlBuilder class, the "where" conditions are represented as an array of conditions, whereas the "having" conditions are represented as a string.

And since I know what the attitude to BC breaks (or general overhauls) is, I'd rather work on it once I know there will be support.

dakujem avatar Mar 26 '20 11:03 dakujem

Of course, this new feature should not cause a BC break…

dg avatar Mar 26 '20 21:03 dg