netlify-plugin-gatsby icon indicating copy to clipboard operation
netlify-plugin-gatsby copied to clipboard

modified loadGatsbyConfig to support TS

Open graydonpleasants opened this issue 2 years ago โ€ข 3 comments

Summary

Modified the plugin to also look for a gatsby-config.ts file, something now supported by Gatsby.

Test plan

  1. Visit the Deploy Preview (insert link to specific page) ...

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Issue I Created

Standard checks:

  • [ ] Check the Deploy Preview's Demo site for your PR's functionality
  • [ ] Add docs when necessary

๐Ÿงช Once merged, make sure to update the version if needed and that it was published correctly.

graydonpleasants avatar Jul 05 '23 18:07 graydonpleasants

Deploy Preview for netlify-plugin-gatsby-demo-v5 ready!

Name Link
Latest commit d630b4d8c1cae39c69193d28a2d4529f57781eca
Latest deploy log https://app.netlify.com/sites/netlify-plugin-gatsby-demo-v5/deploys/64a5b8b8694fce0008eb651d
Deploy Preview https://deploy-preview-646--netlify-plugin-gatsby-demo-v5.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 05 '23 18:07 netlify[bot]

Deploy Preview for netlify-plugin-gatsby-demo ready!

Name Link
Latest commit d630b4d8c1cae39c69193d28a2d4529f57781eca
Latest deploy log https://app.netlify.com/sites/netlify-plugin-gatsby-demo/deploys/64a5b8b840692d0008b85fd8
Deploy Preview https://deploy-preview-646--netlify-plugin-gatsby-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 05 '23 18:07 netlify[bot]

Does this actually work? From reading this it would try to require() a typescript file which wouldn't work in default Node.js environment unless some kind of "transpile TS on the fly hack" was used (for example ts-node/register)

pieh avatar Jul 11 '23 09:07 pieh