netlify-plugin-gatsby

netlify-plugin-gatsby copied to clipboard

The DSG & SSR handler uses the serverDataStatus value to use custom status codes. Defaults to 200

🎉 Thanks for sending this pull request! 🎉

Please make sure the title is clear and descriptive.

If you are fixing a typo or documentation, please skip these instructions.

Otherwise please fill in the sections below.

Which problem is this pull request solving?

Example: I'm always frustrated when [...]

List other issues or pull requests related to this problem

Example: This fixes #5012

Describe the solution you've chosen

Example: I've fixed this by [...]

Describe alternatives you've considered

Example: Another solution would be [...]

Checklist

Please add a x inside each checkbox:

• [ ] I have read the contribution guidelines.
• [ ] I have added tests (we are enforcing 100% test coverage).
• [ ] I have added documentation in the README.md, the docs directory (if any) and the examples directory (if any).
• [ ] The status checks are successful (continuous integration). Those can be seen below.

👷 Deploy request for netlify-plugin-gatsby-demo pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	9f57e4e9fb9634f07e57f873868c0a368d3689e4

Thanks for this! Looking good so far. The issue seems to be with the types for getData. Would this be fixed by updating the version of Gatsby in the demo site, or are the types missing from Gatsby?

Happy to contribute!

Yeah the ISSRData type defined here contains serverDataStatus, but ISSRData in the type declaration file doesn't expose serverDataStatus.

@ascorbic Would you recommend creating a PR in the gatsby repo to include serverDataStatus in the type declaration file as a pre-requisite for this PR, or some other approach? I noticed that the gatsby-plugin-fastify plugin was able to reference serverDataStatus in this update so wasn't sure if I was missing something.

I would do a PR to Gatsby (apart from anything, they'll send you some great swag if you do!). However if you don't want to wait, we did previously define our own types while we waited for them to update the published types, so you might want to do similar here.

Sounds good! This can wait a bit so I'll go ahead and make a PR into the Gatsby repo.

Great! I recommend the jamstack jammies 😄

any updates on this? this feature is essential to work with gatsby ssr on netlify. without we cannot send a 404 statuscode