TagsBundle icon indicating copy to clipboard operation
TagsBundle copied to clipboard

New Criterion "TagSubtree" matching the "path_string" of tags

Open pkamps opened this issue 1 year ago • 3 comments

Hi,

for a client project we need to be able to filter by a tag subtree. For example, there is a parent tag called "Category" and there are multiple children tags like "USA", "World" etc. The content objects only have the tags "USA" or "World" assigned (not the "Category" tag). We want to be able to find/filter all content that has any children tags of the "Category" tag.

Therefore I developed a new custom Criterion matching values against the DB field "eztags.path_string". Is that something you consider to add to the official repo?

pkamps avatar Nov 13 '23 15:11 pkamps

@pkamps This needs running cs fixer to fix some coding standards issues as well as a phpstan error.

I suppose you did not need Solr visitor, hence no implementation?

emodric avatar Nov 23 '23 13:11 emodric

I fixed 1 PHPStan error I introduced. There are 3 remaining but not related to this pull request. I believe I fixed the CS issues but the checker still fails - maybe it's not configured correctly?

So far, I don't need the Solr visitor - should I implement it to make this pull request more complete?

pkamps avatar Nov 26 '23 14:11 pkamps

I fixed 1 PHPStan error I introduced. There are 3 remaining but not related to this pull request. I believe I fixed the CS issues but the checker still fails - maybe it's not configured correctly?

Thanks for the fixes! I have no idea about CS Fixer, it worked on last push to master and I will try to fix lingering PHPStan issues once I merge this.

So far, I don't need the Solr visitor - should I implement it to make this pull request more complete?

If it's not too much trouble :)

emodric avatar Nov 28 '23 09:11 emodric