azure-func-http icon indicating copy to clipboard operation
azure-func-http copied to clipboard

Peer dependencies allows @azure/functions v1 or v3 but not v2

Open bm77525-kr opened this issue 3 years ago • 4 comments

I'm submitting a...


[ ] Regression 
[ ] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

I've noticed that the peer dependencies are pinned to @azure/functions@^1.0.3 and @azure/functions@^3.0.0 but there's no support for @azure/functions@^2.0.0.

Expected behavior

As per the README of the @azure/functions package addressing versioning, v1 of the package is in maintenance mode, v2 supports Azure Function runtime v3 which is not EOL, and v3 supports Azure Function Runtime v4 which is relatively new. Pinning this dependency to v1 or v3 leaves out a large majority of people who are still on Azure Functions runtime v3. If you're still supporting v1, which is in maintenance mode, there should be no reason that @azure/functions@^2.0.0, still in general availability, isn't supported.

I propose a change to:

"peerDependencies": {
    "@azure/functions": "^1.0.3 || ^2.0.0 || ^3.0.0",
    ...
  },

bm77525-kr avatar Apr 26 '22 18:04 bm77525-kr

PRs are more than welcomed :smile_cat:

micalevisk avatar May 23 '22 02:05 micalevisk

PRs are more than welcomed 😸

Happy to. Is there a specific cadence at which releases on this repo are done? I see that not even the v3 @azure/functions package is supported in the latest release (0.8.0 as of writing this).

bm77525-kr avatar May 25 '22 16:05 bm77525-kr

idk

@kamilmysliwiec we have a mismatch between the version here vs the one in the package

https://github.com/nestjs/azure-func-http/blob/ddeb92c468526de8bbe374863ba4a21fb25b26c5/package.json#L23-L24

https://github.com/nestjs/azure-func-http/blob/ddeb92c468526de8bbe374863ba4a21fb25b26c5/package.json#L3

While the published package has:

image

micalevisk avatar May 25 '22 16:05 micalevisk

Any updates on this @kamilmysliwiec?

bm77525-kr avatar Jul 24 '22 17:07 bm77525-kr

https://github.com/nestjs/azure-func-http/commit/eb6eb654fc325b8a5d2539eeef496926fc1b1714

kamilmysliwiec avatar Feb 09 '23 09:02 kamilmysliwiec