ncsms-android

ncsms-android copied to clipboard

I implemented a splashscreen like in Notes, News and (soon) Files app.

~~Attention: This will remove the launcher icon from home screens when the user updates the app (basically the activity changes).~~ With the last commit i managed to keep the old launcher - for the user nothing will change :)

~~I think it might be possible to keep the launchers on the homescreen, if we keep the names, but it will be weird in your code when your MainActivity launches the SplashscreenActivity and the RealMainActivity launches the MainActivity - that's why i implemented it clean ;-)~~ Got some better inspiration by https://github.com/nextcloud/android/pull/2448/files

Good news @nerzhul, i got some inspiration by https://github.com/nextcloud/android/pull/2448/files to keep the former launcher on the homescreen.

So i think this PR is safe to merge without breaking changes for the users :)

@nerzhul any concerns about this PR? Can i provide more information or help you?

pinging @nerzhul about this open PR ❤️

i'm not sure it's useful, app load very fast

Do you see disadvantages?

I think there are three reasons why this should be merged:

1. There is no artificial timeout or something like this - the splash screen does not slow down the app start but shows while the natural start process
2. Nearly all nextcloud ecosystem apps are doing this the same way - user will feel more comfortable, more like being "at home" when all the Nextcloud apps will have a similiar look and feel (just like the story about the adaptive icons, you remember?)
3. Think about older or cheaper devices. Sure, on your device it might work fast, but there are a plenty of users with old weak or cheap phones, where many apps are running in the background

In short: you don't know in which environement your app will run. So if there are no disadvantages for you, but there mght be advantages fore others, why not?

@nerzhul currently has not much time for the Nextcloud apps. Maybe @nerzhul you can add @stefan-niedermann as a maintainer to this repository/app?

@stefan-niedermann It would be awesome if we could get the Nextcloud SMS app back on track again. Would you be interested in maintaining the client?

I am currently very busy with the Notes and Deck android app, therefore i don't have much time unfortunately.