act
act copied to clipboard
Add support for GHA services
Original PR: https://github.com/nektos/act/pull/638 Fixes https://github.com/nektos/act/issues/173
Changes:
- add support for
services - creates network linked between all containers
- fixes job context to include container and services contexts
To do:
- [x] Add more testcases
- [x] Multiple sanity checks that code doesn't look terrible
- [ ] Fix job context
@catthehacker this pull request has failed checks ðŸ›
Codecov Report
Merging #775 (453d1f0) into master (0f04942) will increase coverage by
7.07%. The diff coverage is59.90%.
:exclamation: Current head 453d1f0 differs from pull request most recent head 90a47e9. Consider uploading reports for the commit 90a47e9 to get more accurate results
@@ Coverage Diff @@
## master #775 +/- ##
==========================================
+ Coverage 49.27% 56.34% +7.07%
==========================================
Files 23 29 +6
Lines 2401 4316 +1915
==========================================
+ Hits 1183 2432 +1249
- Misses 1090 1677 +587
- Partials 128 207 +79
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/common/executor.go | 46.90% <0.00%> (+2.03%) |
:arrow_up: |
| pkg/common/job_error.go | 0.00% <0.00%> (ø) |
|
| pkg/common/outbound_ip.go | 0.00% <0.00%> (ø) |
|
| pkg/common/testflag.go | 0.00% <0.00%> (ø) |
|
| pkg/container/docker_network.go | 0.00% <0.00%> (ø) |
|
| pkg/container/docker_volume.go | 0.00% <0.00%> (ø) |
|
| pkg/model/action.go | 0.00% <ø> (ø) |
|
| pkg/container/docker_run.go | 5.15% <9.24%> (+3.22%) |
:arrow_up: |
| pkg/common/git.go | 49.82% <31.81%> (-9.97%) |
:arrow_down: |
| pkg/runner/logger.go | 65.43% <37.50%> (+1.28%) |
:arrow_up: |
| ... and 36 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 4e0ba61...90a47e9. Read the comment docs.
Can you rebase this PR? 😀
@catthehacker this pull request has failed checks ðŸ›
@catthehacker this pull request is now in conflict 😩
Is this or something like it likely to land or does it not have a future? Would love to use services in a new CD workflow I'm setting up ...
@acorncom I think a PR is more than welcome. But it is not the smallest topic :wink:
@KnisterPeter I gathered 😉 Afraid I probably can't help with it right now sadly ...
This PR is almost complete, the only thing missing is that it breaks after fixing job context