act icon indicating copy to clipboard operation
act copied to clipboard

Add support for GHA services

Open catthehacker opened this issue 4 years ago • 5 comments

Original PR: https://github.com/nektos/act/pull/638 Fixes https://github.com/nektos/act/issues/173

Changes:

  • add support for services
  • creates network linked between all containers
  • fixes job context to include container and services contexts

To do:

  • [x] Add more testcases
  • [x] Multiple sanity checks that code doesn't look terrible
  • [ ] Fix job context

catthehacker avatar Aug 11 '21 02:08 catthehacker

@catthehacker this pull request has failed checks 🛠

mergify[bot] avatar Aug 11 '21 02:08 mergify[bot]

Codecov Report

Merging #775 (453d1f0) into master (0f04942) will increase coverage by 7.07%. The diff coverage is 59.90%.

:exclamation: Current head 453d1f0 differs from pull request most recent head 90a47e9. Consider uploading reports for the commit 90a47e9 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
+ Coverage   49.27%   56.34%   +7.07%     
==========================================
  Files          23       29       +6     
  Lines        2401     4316    +1915     
==========================================
+ Hits         1183     2432    +1249     
- Misses       1090     1677     +587     
- Partials      128      207      +79     
Impacted Files Coverage Δ
pkg/common/executor.go 46.90% <0.00%> (+2.03%) :arrow_up:
pkg/common/job_error.go 0.00% <0.00%> (ø)
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/common/testflag.go 0.00% <0.00%> (ø)
pkg/container/docker_network.go 0.00% <0.00%> (ø)
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <ø> (ø)
pkg/container/docker_run.go 5.15% <9.24%> (+3.22%) :arrow_up:
pkg/common/git.go 49.82% <31.81%> (-9.97%) :arrow_down:
pkg/runner/logger.go 65.43% <37.50%> (+1.28%) :arrow_up:
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e0ba61...90a47e9. Read the comment docs.

codecov[bot] avatar Aug 11 '21 02:08 codecov[bot]

Can you rebase this PR? 😀

till avatar Nov 05 '21 07:11 till

@catthehacker this pull request has failed checks 🛠

mergify[bot] avatar Nov 05 '21 08:11 mergify[bot]

@catthehacker this pull request is now in conflict 😩

mergify[bot] avatar Nov 27 '21 18:11 mergify[bot]

Is this or something like it likely to land or does it not have a future? Would love to use services in a new CD workflow I'm setting up ...

acorncom avatar Sep 13 '22 09:09 acorncom

@acorncom I think a PR is more than welcome. But it is not the smallest topic :wink:

KnisterPeter avatar Sep 13 '22 09:09 KnisterPeter

@KnisterPeter I gathered 😉 Afraid I probably can't help with it right now sadly ...

acorncom avatar Sep 13 '22 11:09 acorncom

This PR is almost complete, the only thing missing is that it breaks after fixing job context

catthehacker avatar Sep 14 '22 17:09 catthehacker