act icon indicating copy to clipboard operation
act copied to clipboard

build(deps): chocolatey - update alpine to 3.17

Open ChristopherHX opened this issue 2 years ago • 3 comments
trafficstars

I updated two PR's and the snapshot fails, because the latest mono-dev fails to find it's dependency in the old alpine base image

This package is not found in v3.16 or older https://pkgs.alpinelinux.org/packages?name=libgdiplus-dev&branch=v3.17&repo=&arch=&maintainer=

ChristopherHX avatar Dec 18 '22 12:12 ChristopherHX

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.0s
✅ REPOSITORY gitleaks yes no 2.87s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 1.19s

See errors details in artifact MegaLinter reports on CI Job page Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

github-actions[bot] avatar Dec 18 '22 12:12 github-actions[bot]

Codecov Report

Merging #1512 (09dd1d5) into master (4f8da0a) will increase coverage by 3.85%. The diff coverage is 67.64%.

@@            Coverage Diff             @@
##           master    #1512      +/-   ##
==========================================
+ Coverage   57.50%   61.36%   +3.85%     
==========================================
  Files          32       46      +14     
  Lines        4594     7121    +2527     
==========================================
+ Hits         2642     4370    +1728     
- Misses       1729     2444     +715     
- Partials      223      307      +84     
Impacted Files Coverage Δ
pkg/common/file.go 0.00% <0.00%> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/container/parse_env_file.go 0.00% <0.00%> (ø)
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/container/docker_run.go 13.58% <11.48%> (+8.04%) :arrow_up:
pkg/model/workflow.go 42.11% <18.51%> (-8.80%) :arrow_down:
...ontainer/linux_container_environment_extensions.go 24.32% <24.32%> (ø)
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
... and 38 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Dec 18 '22 12:12 codecov[bot]

Seems like alpine uploaded the missing package to alpine 3.16 today, but updating alpine is still a good idea.

ChristopherHX avatar Dec 19 '22 15:12 ChristopherHX

We should switch to https://hub.docker.com/r/chocolatey/choco as it's official image from chocolatey project

catthehacker avatar Dec 19 '22 19:12 catthehacker

I agree, we should switch to the official image. Not shure what needs to be done to switch to the official image.

PR 1514 contains this change, because I was surprised that the PR checks will succeed today without it

ChristopherHX avatar Dec 19 '22 20:12 ChristopherHX

Merged implicitly via #1514, not the order I expected

ChristopherHX avatar Dec 19 '22 21:12 ChristopherHX