neilyoung

Results 210 comments of neilyoung

~~Hmm. Thanks. At least from the release notes it looks like so. But I can't checkout that tag, somehow. Any hint?~~ Disregard please. Typo in version

Yes it works. And they have adopted your solution. It remains a hack (no offence)

Hmm. Now I'm not sure anymore. Let me checkout master again and then the RC. I had applied your patch manually... I stashed it and checked out the RC... Later...

That parcel build is strange. Look at this. Error in run 1, ok in run 2: ``` ~/Documents/test/peerjs $ npm run build > [email protected] build > rm -rf dist &&...

Hasn't this been one of your changes? To negoiator.ts? It is in now. ``` if (options.originator) { if (this.connection.type === ConnectionType.Data) { const dataConnection = (this.connection); const config: RTCDataChannelInit =...

I'm not sure if it is worth the efforts. This project seems to be pretty dead. And it doesn't support iterative addition/removal of streams, like lets start with data, then...

BTW: You did fine. You solved the problem. That's ok.

@Danappelxx: I'm not the project owner, but I suppose this project is discontinued. I personally made a new "Framework" project in XCode 7 from scratch with all my sources, that...

@zittix: My framework is not supposed to run in simulator because it is close to real device hardware, but when I started I checked out this tutorial http://insert.io/framework-ios8-xcode6/. The script...

Yes, you might be right. I was just "knocking on the bush". However, even there is a patch, this seems to introduce a circular reference, if I get that right....