react-native-web icon indicating copy to clipboard operation
react-native-web copied to clipboard

ScrollView for Web

Open necolas opened this issue 5 years ago • 11 comments

ScrollView for Web

TBD…but this needs a rewrite using function components and hooks.

necolas avatar Apr 16 '20 06:04 necolas

Hey @necolas! Can I pick this issue up?

V1shvesh avatar Oct 09 '20 12:10 V1shvesh

How's this effort going, and what does it mean when this gets done?

jkoutavas avatar Jan 25 '21 13:01 jkoutavas

Hey @jkoutavas, I never picked this up since @necolas had self-assigned this issue. @necolas I would be happy to help if you're looking for contributions.

V1shvesh avatar Mar 01 '21 18:03 V1shvesh

@V1shvesh I think you should just go and provide a merge-request for @necolas

chris-aeviator avatar Mar 12 '21 08:03 chris-aeviator

@necolas could you point out which parts in your initial idea would be modified, I'll happily contribute if it looks doable to me.

chris-aeviator avatar Mar 25 '21 19:03 chris-aeviator

The component need converting to a functional component and the scroll responder needs to be integrated in an entirely different way (see RN code). The functional component rewrite is currently in progress for RN and can act as a reference point once it lands in the OSS repo

necolas avatar Mar 25 '21 19:03 necolas

@necolas thanks for the quick response - for understanding better the issue, why is e.g. the scrollview in the demo perfectly scrollable?

grafik

chris-aeviator avatar Mar 25 '21 19:03 chris-aeviator

Were you expecting it not to work!? This task is to change the implementation details of the component

necolas avatar Mar 25 '21 19:03 necolas

Seems like a bit of a misunderstanding - I indeed have a non-scrolling ScrollView in an react-native (expo) app when compiling to web :grinning:

chris-aeviator avatar Mar 25 '21 19:03 chris-aeviator

@chris-aeviator this is likely due to not having a View wrapping your ScrollView with a fixed height.

If you have issues scrolling, pass style={{ flex: 1 }} or style={StyleSheet.absoluteFill} to a View that wraps your ScrollView.

nandorojo avatar Aug 26 '21 00:08 nandorojo

Is it expected that ScrollView's listeners (onMomentumScrollEnd, onScrollEndDrag) don't work for Web? They just happen during the initial render, or if the content size changes, but they don't seem to listen to actual user drag or scroll events.

camello222 avatar Mar 29 '22 01:03 camello222