Norbert de Langen

Results 392 comments of Norbert de Langen

The future of storyshots is the test-runner: https://storybook.js.org/docs/react/writing-tests/test-runner#page-top And use the play function for expectations: https://storybook.js.org/docs/react/writing-stories/play-function#page-top We will not be making any improvement / changes to storyshots.

@Amerlander it seems this PR wasn't given a lot of attention and that's on us, sorry that that happened. Now we're faced with to consequences unfortunately.. This PR is very...

What makes you suggest that @jtstothard ? Do you have a reproduction?

Our `dist` should not be referencing `react-textarea-autosize` at all, it's bundled in. I'm confused how this could still be an issue. Does anyone have a reproduction I could see this...

Bundled in, means that the output `dist` will contain the package. That import will be gone in `dist`. So yes, it's a devDependency, because at runtime this reference should not...

OK, I see this in our dist: ![Screenshot 2023-12-15 at 09 20 13](https://github.com/storybookjs/storybook/assets/3070389/e161307f-1ccf-4128-ad5b-c423a03f438b) So that confirms the issue.. I'm not sure why `tsup` isn't bundling the type-definitions in, I'll see...

@zigang93 could you supply a reproduction repo?

Without a reproduction there's nothing we can really do.