streamrip icon indicating copy to clipboard operation
streamrip copied to clipboard

[BUG] source_subdirectories does not use subfolders any more

Open AllKind opened this issue 1 year ago • 8 comments

Describe the bug

Using source_subdirectories = true does not create / honour the respective folders any more (tested Qobuz and Tidal).

Command Used

rip url https://play.qobuz.com/artist/XXXXX
rip url https://tidal.com/browse/track/XXXXX

Debug Traceback

No traceback as download works.

Config File

downloads]
# Folder where tracks are downloaded to
folder = "/storage/pub/tmp/stream_dl/streamrip"
# Put Qobuz albums in a 'Qobuz' folder, Tidal albums in 'Tidal' etc.
source_subdirectories = true

# Download (and convert) tracks all at once, instead of sequentially. 
# If you are converting the tracks, or have fast internet, this will 
# substantially improve processing speed.
concurrency = true
# The maximum number of tracks to download at once
# If you have very fast internet, you will benefit from a higher value,
# A value that is too high for your bandwidth may cause slowdowns
# Set to -1 for no limit
max_connections = 3
# Max number of API requests per source to handle per minute
# Set to -1 for no limit
requests_per_minute = 60

Operating System

Linux (Mint 21.3)

streamrip version

2.0.2

Screenshots and recordings

No response

Additional context

python 3.10 btw: had to uninstall (after upgrade to 2.0.2) and reinstall streamrip (pip3) to get the login (email) working with Qobuz. Else it would fail with invalid secrets error.

AllKind avatar Jan 13 '24 17:01 AllKind

This seems to be connected to #543

jettycake avatar Jan 13 '24 18:01 jettycake

This seems to be connected to #543

I agree. Having these same issues.

Seb3thehacker avatar Jan 13 '24 22:01 Seb3thehacker

I have to re-open this, as single tracks still do not go into the sub-folders.

AllKind avatar Jan 31 '24 11:01 AllKind

Do you have add_singles_to_folder = true?

nathom avatar Jan 31 '24 18:01 nathom

no

AllKind avatar Jan 31 '24 18:01 AllKind

If you turn it on, it should work.

nathom avatar Feb 01 '24 02:02 nathom

Maybe... But that's not what I want. I'd like the old (pre 2.x) behaviour. It also is logical, if you set source_subdirectories, that all downloads go into download_folder/source. Because after I download, I send the files to the program beets (-s parameter for singles) - for tagging. And it's easier to distinguish between singles and albums, if the singles are not in a folder.

AllKind avatar Feb 02 '24 21:02 AllKind

The current behavior also has the problem, when downloading more than one track, the covers for a each song are downloaded and overwrite each other.

AllKind avatar Feb 16 '24 15:02 AllKind