apod-api icon indicating copy to clipboard operation
apod-api copied to clipboard

Published 20 hours ago • verified publisher icon nasa

Formatting and Pytests

Open maxmarzolf opened this issue 4 years ago • 5 comments

  • Added urllib3 to requirements.txt
  • Abbreviated props dictionary creation as dictionary literal in utility.py
  • Fixed typo in get_explanation function
  • Made formatting PEP 8 compliant

maxmarzolf avatar Apr 30 '21 21:04 maxmarzolf

Can you explain all the changes to the requirements.txt file. It isn't just the addition of urllib3.

JustinGOSSES avatar Oct 15 '21 14:10 JustinGOSSES

Can you explain all the changes to the requirements.txt file. It isn't just the addition of urllib3.

hmm I only intended to add urllib3, not sure why more than that was changed :)

maxmarzolf avatar Oct 17 '21 22:10 maxmarzolf

Would be happy to put more work in, thanks.

maxmarzolf avatar Aug 24 '22 19:08 maxmarzolf

Can you explain all the changes to the requirements.txt file. It isn't just the addition of urllib3.

hmm I only intended to add urllib3, not sure why more than that was changed :)

This PR has been open for more than 1.5 years. Is it still relevant ?

tejusp avatar Aug 28 '22 18:08 tejusp

Can you explain all the changes to the requirements.txt file. It isn't just the addition of urllib3.

hmm I only intended to add urllib3, not sure why more than that was changed :)

This PR has been open for more than 1.5 years. Is it still relevant ?

I think so, the last sentence in the readme says, "If you would like to contribute, right now we could use some attention to the tests." which is what this PR aims to develop.

maxmarzolf avatar Aug 29 '22 13:08 maxmarzolf