Chau Tran
Chau Tran
Hi @nontangent , thank you for the contribution. Can you add some tests to verify the behavior of whether the `srcRootForCompilationRoot` is provided or not?
@geofmigliacci thank you for the offer. Since it is a schema change to the `tsc` executor, we'd have an e2e test for it. You can look into: `e2e/js/src/js.test.ts` to see...
@SeanSanker hey, thanks for the PR. Can we add an e2e test for this?
Since the PR author hasn't been active for the past 2 weeks, I'll try to add some e2e tests to this PR. Thank you for your patience everyone
@SeanSanker Hi Sean, thank you for reporting back. I haven't started but I have some free-time carved out for this PR so I'm going to write the test based on...
@bulldog98 , thank you for the PR. Can you add some e2e tests for this change?
@bulldog98 I've rebased the branch and kicked off the build which is failing. Can you take a look? To run test locally, you'd need to start `local-registry` with: ``` yarn...
@bulldog98 Thanks for the PR. Everything looks good so far. Just one quick question, why did you have the following? ```ts ... const dynamicImport = new Function('specifier', 'return import(specifier)'); ......
@luxaritas yep, that's my concern as well. I also think the real fix is to support ESM across the board. With TS 4.7, we have a more "official" ESM support...