napalm-huawei-vrp icon indicating copy to clipboard operation
napalm-huawei-vrp copied to clipboard

Published 20 hours ago • verified publisher icon napalm-automation-community

fix get_facts, get_interface, get_interface_ip

Open vladislav-tenishchev opened this issue 1 year ago • 5 comments

Good afternoon! Conflict resolution didn't go according to plan, so I created a new repository and put my fixes there. I would like to present some fixes for the library. In particular, fixing the duplication of the Dialer interface in the get_interfaces output, also for this interface, the ip address is now displayed. Also provided get_facts fixes for huawei AR and NE devices. If you consider including this pull request in the master branch, I would appreciate it.

vladislav-tenishchev avatar Nov 14 '23 12:11 vladislav-tenishchev

Hi @vladislav-tenishchev

The new code failed the Checks i have included recently. It's failing in Black format check. As napalm original project, we have included Black formatter check to this project, please format the code using Black formatter and push the code again.

We appreciate your contribution to this project.

codingnetworksb avatar Dec 02 '23 13:12 codingnetworksb

Good afternoon, @codingnetworksb. Okay, I'll get to that soon

vladislav-tenishchev avatar Dec 10 '23 15:12 vladislav-tenishchev

Good afternoon, @codingnetworksb. i'm formatted the code using black

vladislav-tenishchev avatar Dec 19 '23 08:12 vladislav-tenishchev

Good afternoon, @codingnetworksb, haven't seen the changes?

vladislav-tenishchev avatar Apr 20 '24 21:04 vladislav-tenishchev