terraformize

terraformize copied to clipboard

Fixes #17

• this resolves all concurrency issues when using a remote backend and allows for true scaling of the application.
• local backend usage is fully preserved.

Hello @chasebolt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file terraformize/terraformize_configure.py:

Line 29:80: E501 line too long (104 > 79 characters)

• In the file terraformize/terraformize_endpoint.py:

Line 103:80: E501 line too long (88 > 79 characters) Line 104:80: E501 line too long (100 > 79 characters) Line 143:80: E501 line too long (88 > 79 characters) Line 144:80: E501 line too long (100 > 79 characters)

• In the file terraformize/terraformize_terraform_wrapper.py:

Line 15:80: E501 line too long (86 > 79 characters) Line 18:80: E501 line too long (117 > 79 characters) Line 24:80: E501 line too long (106 > 79 characters) Line 25:80: E501 line too long (80 > 79 characters) Line 26:80: E501 line too long (86 > 79 characters) Line 29:80: E501 line too long (84 > 79 characters) Line 31:80: E501 line too long (100 > 79 characters) Line 32:80: E501 line too long (109 > 79 characters) Line 35:80: E501 line too long (88 > 79 characters) Line 66:80: E501 line too long (84 > 79 characters) Line 86:80: E501 line too long (86 > 79 characters)

• In the file test/test_terraformize_terraform_wrapper.py:

Line 18:80: E501 line too long (111 > 79 characters) Line 23:80: E501 line too long (92 > 79 characters) Line 24:80: E501 line too long (111 > 79 characters) Line 29:80: E501 line too long (85 > 79 characters) Line 38:80: E501 line too long (85 > 79 characters) Line 47:80: E501 line too long (85 > 79 characters) Line 56:80: E501 line too long (85 > 79 characters) Line 64:80: E501 line too long (85 > 79 characters) Line 72:80: E501 line too long (85 > 79 characters) Line 80:80: E501 line too long (84 > 79 characters)

Comment last updated at 2019-12-13 00:24:01 UTC

damn that typobot is rough hah. ill fix the failing tests in the morning along with the style issues.

let me know what you think about this, personally i need this functionality but would prefer not to run on a fork.

Sorry about the million changes requested, I see the direction your taking it but as it's a rather big refactor there are a lot of little bugs in it that needs ironing out before it can be safely merged.

not a problem. i will go ahead and move to my own fork. i've been testing extensively and these changes fixed all of the concurrency bugs. in the state the master branch is in, while the README states it is scalable and safe, that is not true even with a remote backend.

i appreciate the inspiration for this project!

I think you misunderstood.

I agree that this change is needed just that the merge will happen after the syntax\unit-test\misc issues are resolved.

whats your thought on bumping the line length to 119? that is closer to the standard these days and django is 119 as well.

github code viewer/editor also defaults to 120. looking at the style remarks, it is complaining on lines that are much shorter than other lines around it and im unsure on why that is.

other than styling, this PR is complete.

Python has a styling guide named PEP8 which is where the 79 line length comes from, I tend to prefer to sticking to the language best practice even if personally I agree that with modern widescreen monitors it could be safely increased.

thats fine, but a huge chunk of this code does not fit the PEP8 line length. can you please look into this and confirm that? it is currently complaining about lines that are over 79 characters, while all the lines around it are much longer.

it looks like PEP8 bot got implemented after majority of this code was written and only enforcing these rules on new code comitted.

Your right about the pep8 bot so let's keep it at 119 for the time being & I'll have it changed to 79 project wide down the road

line lengths are less than 120 chars now. all tests pass and is ready to go.