nf-interpreter

nf-interpreter copied to clipboard

Description

• Add littlefs to build system.
• Replacing and removing Win.Storage from ChibiOS and Azure RTOS targets.
• Temporarily removing support for SDCard and USB MSD in ORGPALTHREE.

Motivation and Context

• Need to replace SPIFFs with an alternative library that is actively maintained, plus it has better performance.
• Resolves nanoframework/Home#534.
• Resolves nanoframework/Home#1229.
• Resolves nanoframework/Home#808.
• Resolves nanoframework/Home#799.

How Has This Been Tested?

Screenshots

Types of changes

• [ ] Improvement (non-breaking change that improves a feature, code or algorithm)
• [ ] Bug fix (non-breaking change which fixes an issue with code or algorithm)
• [x] New feature (non-breaking change which adds functionality to code)
• [x] Breaking change (fix or feature that would cause existing functionality to change)
• [x] Config and build (change in the configuration and build system, has no impact on code or features)
• [x] Dev Containers (changes related with Dev Containers, has no impact on code or features)
• [ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
• [ ] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

• [x] My code follows the code style of this project (only if there are changes in source code).
• [ ] My changes require an update to the documentation (there are changes that require the docs website to be updated).
• [ ] I have updated the documentation accordingly (the changes require an update on the docs in this repo).
• [x] I have read the CONTRIBUTING document.
• [x] I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Current issue seems to be:

and/or undefined ref to lfsFileSystemReady

For ESP32:

Note: there is no need to continually bump the dockerfile version for smoke tests to succeed. The CI uses the SRC file as default, so the PR should only bump by one version when ready to merge.

Failed build for the STM32F769I still amount to:

Aaallllmmooooost there! 😅

[!IMPORTANT]

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

70 files out of 212 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

@MateuszKlatecki following this, NXP is the last target using Win.Storage. Any change you guys can put some work on this and migrate to the new FileSystem namespace and implementation so we can get rid of Win-Storage for good? Thanks!