nf-interpreter icon indicating copy to clipboard operation
nf-interpreter copied to clipboard

Published 20 hours ago • verified publisher icon nanoframework

GRAPHICS for ST_STM32F429I_DISCOVERY

Open jooos5 opened this issue 3 years ago • 20 comments

Description

  • Adds LCD GRAPHICS for the ST_STM32F429I_DISCOVERY

Motivation and Context

  • This board has an LCD.

How Has This Been Tested?

Screenshots

Types of changes

  • [ ] Improvement (non-breaking change that improves a feature, code or algorithm)
  • [ ] Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • [x] New feature (non-breaking change which adds functionality to code)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Config and build (change in the configuration and build system, has no impact on code or features)
  • [ ] Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • [ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
  • [ ] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • [ ] My code follows the code style of this project (only if there are changes in source code).
  • [ ] My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • [ ] I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

jooos5 avatar May 13 '22 13:05 jooos5

CLA assistant check
All CLA requirements met.

dnfadmin avatar May 13 '22 13:05 dnfadmin

@jooos5 , Just a suggestion for the future, I would recommend you create a new branch (in your fork) and make the changes there. It will allow you to make further commits without having to tear down your current repo and starting again.

But thanks for the PR 💯.

networkfusion avatar May 13 '22 23:05 networkfusion

@jooos5 can you please address the build failure? (also make sure to pull the latest changes from upstream)

josesimoes avatar May 30 '22 10:05 josesimoes

@jooos5 any progress on this please? Just that more UI code is changing and it can have impact here. The longer this remains stalled harder to keep up. 😉

josesimoes avatar Jun 01 '22 23:06 josesimoes

I made a note directly against the fork regarding the need for accepting the code style fixes. I am not sure if the GH notifications are being monitored 😒 . Do we know how to ping this user on discord?

networkfusion avatar Jun 01 '22 23:06 networkfusion

@josesimoes I am so sorry. I don't have time to work on my fork right now :-(

jooos5 avatar Jun 02 '22 09:06 jooos5

I have manually added the code style fixes to help push this PR along, however it still has an error: image

Hopefully it is simple to fix.

networkfusion avatar Jun 27 '22 12:06 networkfusion

@jooos5 any chance you can sign the CLA? The team will take over and fix the remaining issues.

josesimoes avatar Jun 28 '22 00:06 josesimoes

@jooos5 any chance you can sign the CLA? The team will take over and fix the remaining issues.

How should I do it? I do not know

jooos5 avatar Jul 15 '22 10:07 jooos5

@jooos5 just scrool up and you'll see the following. You have to click there to sign.

image

josesimoes avatar Jul 15 '22 10:07 josesimoes

what should I choose to allow the team to fix problems?

jooos5 avatar Jul 15 '22 11:07 jooos5

Sorry that I did not reply for a while. relaxing at sea :)

jooos5 avatar Jul 15 '22 11:07 jooos5

what should I choose to allow the team to fix problems?

You just have to sign the CLA. Only after that your code can be merged and after that we'll be able to change and fix whatever is required.

josesimoes avatar Jul 15 '22 11:07 josesimoes

@jooos5 @networkfusion I've fixed the build error. Please confirm if this is working as it is now so it can be merged.

josesimoes avatar Jul 29 '22 12:07 josesimoes

on the STM32F429i-Discovery board driver of touchscreen with I2C interface (STMPE811).

jooos5 avatar Aug 01 '22 12:08 jooos5

@jooos5 there are issues with the code style on the source files. A PR was submitted with the code style fixes. Please click https://github.com/jooos5/nf-interpreter/pull/7, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

nfbot avatar Aug 08 '22 10:08 nfbot

@jooos5 there are issues with the code style on the source files. A PR was submitted with the code style fixes. Please click https://github.com/jooos5/nf-interpreter/pull/8, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

nfbot avatar Aug 08 '22 10:08 nfbot

@jooos5 can you please merge this PR with the code style fixes? https://github.com/jooos5/nf-interpreter/pull/7

josesimoes avatar Aug 19 '22 07:08 josesimoes

Suddenly, there seems to be multiple changes to CmakePresets.Json since this PR was approved. I am worried that it will break things if merged 😞

networkfusion avatar Aug 21 '22 20:08 networkfusion

@jooos5 can you please address the review comments so this can move forward?

josesimoes avatar Sep 22 '22 07:09 josesimoes

@jooos5 thank you again for your contribution! :pray::smile:

.NET nanoFramework it's all about community involvement and no contribution is too small. We would like to invite you to join the project Contributors list.

Please edit it and add an entry with your GitHub user in the appropriate location (names sorted alphabetically):

  <tr>
    <td><img src="https://github.com/jooos5.png?size=50&" height="50" width="50" ></td>
    <td><a href="https://github.com/jooos5"></a></td>
  </tr>

(feel free to adjust your name, if it's not correct)

nfbot avatar Jan 17 '23 00:01 nfbot