nanoFramework.Hardware.Esp32

nanoFramework.Hardware.Esp32 copied to clipboard

Description

• extended GPIO wakeup pin numbering to include all possible pins
• previously this was limited to a specific implementation
• Please note that I was NOT able to get touchpad working using the functionality within nanoFramework.Hardware.Esp32.Sleep
• the changes here are applicable to ext0 and ext1 sleep wakeup modes

Motivation and Context

• ESP32 S2, specifically Adafruit FeatherS2 was not possible to configure using existing numbering, this fixes the issue

How Has This Been Tested?

Screenshots

Types of changes

• [x] Improvement (non-breaking change that improves a feature, code or algorithm)
• [x] Bug fix (non-breaking change which fixes an issue with code or algorithm)
• [ ] New feature (non-breaking change which adds functionality to code)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Config and build (change in the configuration and build system, has no impact on code or features)
• [ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
• [ ] Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
• [ ] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

• [x] My code follows the code style of this project (only if there are changes in source code).
• [ ] My changes require an update to the documentation (there are changes that require the docs website to be updated).
• [ ] I have updated the documentation accordingly (the changes require an update on the docs in this repo).
• [ ] I have read the CONTRIBUTING document.
• [ ] I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
• [ ] I have added new tests to cover my changes.

@josesimoes I see another PR touch......, touch doesn't otherwise appear to be working using the functionality provided currently in Esp32.Sleep although ext0 and ext1 wakeups are working. Therefore pin combinations can be applied for wakeup, and wakeup occurs.... but I think it is working without the capacitive touch enhancement which would be possible with the other PR. Is there any intent to complete the touch PR ?

@MichaelWheeley that PR has been opened a long time ago. The author never proceed to finish it... I'm not even sure if it's still usable anymore. If you would like to tackle this please go ahead.

In case the work on that PR it's worth using, let me know. I can merge it on a working branch and you can take it from there.

@josesimoes looks like there's some ESP32 native functionality missing to make it work so I'll try to understand how the nf-interpreter is built, I see your excellent instructions.

ty mrw

@MichaelWheeley just catching up on this: any progress at your end? Anything I can help with?

@josesimoes The contents of this PR has now been covered by other PRs #185 for Wakeup pins #189 for Wakeups causes The touch changes are no longer relevant

So this PR can be closed

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.